You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Dr. Martin Menzel (JIRA)" <ji...@apache.org> on 2011/06/12 10:57:51 UTC

[jira] [Created] (CAMEL-4093) s/Mime signed Mails lead to Exceptions in pop3 component

s/Mime signed Mails lead to Exceptions in pop3 component
--------------------------------------------------------

                 Key: CAMEL-4093
                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
             Project: Camel
          Issue Type: Bug
          Components: camel-mail
    Affects Versions: 2.7.2
         Environment: Solaris and Windows
            Reporter: Dr. Martin Menzel


If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.

I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4093) s/Mime signed Mails lead to Exceptions in pop3 component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-4093:
-------------------------------

    Fix Version/s: 2.9.0
                   2.8.0

> s/Mime signed Mails lead to Exceptions in pop3 component
> --------------------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>             Fix For: 2.8.0, 2.9.0
>
>         Attachments: CAMEL-4093.diff
>
>
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Dr. Martin Menzel (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dr. Martin Menzel updated CAMEL-4093:
-------------------------------------

    Description: 
Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component

If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.

I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

------------ additional remark -------------

During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).

=> The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  

deliverRawMailMessage

example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true

I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

  was:
If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.

I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

------------ additional remark -------------

During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).

=> The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  

deliverRawMailMessage

example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true

I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

        Summary: pop3 component parameter deliverRawMailMessage  (was: s/Mime signed Mails lead to Exceptions in pop3 component)

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4093) s/Mime signed Mails lead to Exceptions in pop3 component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048293#comment-13048293 ] 

Claus Ibsen commented on CAMEL-4093:
------------------------------------

Thanks for reporting. Can you provide unit tests with your patch?

> s/Mime signed Mails lead to Exceptions in pop3 component
> --------------------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>             Fix For: 2.8.0, 2.9.0
>
>         Attachments: CAMEL-4093.diff
>
>
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Richard Kettelerij (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064697#comment-13064697 ] 

Richard Kettelerij commented on CAMEL-4093:
-------------------------------------------

Updated docs + release notes.

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: CAMEL-4093-mapMailMessage.patch, CAMEL-4093.diff, CAMEL-4093_with_adapted_unit_test_regarding_MailMessageClass.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Richard Kettelerij (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055101#comment-13055101 ] 

Richard Kettelerij edited comment on CAMEL-4093 at 6/26/11 3:28 PM:
--------------------------------------------------------------------

@Martin, with my patch your "testRawMessageByMailMessageClassConsumer" test should succeed.

      was (Author: rkettelerij):
    @Martin, with my patch you're "testRawMessageByMailMessageClassConsumer" should succeed.
  
> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093-mapMailMessage.patch, CAMEL-4093.diff, CAMEL-4093_with_adapted_unit_test_regarding_MailMessageClass.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055049#comment-13055049 ] 

Claus Ibsen commented on CAMEL-4093:
------------------------------------

Richard wait a bit on this one as we should take a bit care to not add to much stuff into our components. There is some pieces in this patch I would like to discuss/review a bit more.

I suggest to postpone this for Camel 2.9.

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4093) s/Mime signed Mails lead to Exceptions in pop3 component

Posted by "Dr. Martin Menzel (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dr. Martin Menzel updated CAMEL-4093:
-------------------------------------

    Attachment: CAMEL-4093.diff

> s/Mime signed Mails lead to Exceptions in pop3 component
> --------------------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>         Attachments: CAMEL-4093.diff
>
>
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Richard Kettelerij (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055101#comment-13055101 ] 

Richard Kettelerij commented on CAMEL-4093:
-------------------------------------------

@Martin, with my patch you're "testRawMessageByMailMessageClassConsumer" should succeed.

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093-mapMailMessage.patch, CAMEL-4093.diff, CAMEL-4093_with_adapted_unit_test_regarding_MailMessageClass.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4093) s/Mime signed Mails lead to Exceptions in pop3 component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048479#comment-13048479 ] 

Claus Ibsen commented on CAMEL-4093:
------------------------------------

Yeah if you look at the other unit tests, they use a Mocked Mail server. So just copy an existing unit test and modify it.

> s/Mime signed Mails lead to Exceptions in pop3 component
> --------------------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>             Fix For: 2.8.0, 2.9.0
>
>         Attachments: CAMEL-4093.diff
>
>
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Richard Kettelerij (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Kettelerij resolved CAMEL-4093.
---------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.9.0)
                   2.8.0

Resolved (trunk: 1145884). Will update the website soon.

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: CAMEL-4093-mapMailMessage.patch, CAMEL-4093.diff, CAMEL-4093_with_adapted_unit_test_regarding_MailMessageClass.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4093) s/Mime signed Mails lead to Exceptions in pop3 component

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-4093:
-------------------------------

         Priority: Minor  (was: Major)
    Fix Version/s:     (was: 2.8.0)

> s/Mime signed Mails lead to Exceptions in pop3 component
> --------------------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093.diff
>
>
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Richard Kettelerij (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055101#comment-13055101 ] 

Richard Kettelerij edited comment on CAMEL-4093 at 6/26/11 4:50 PM:
--------------------------------------------------------------------

@Martin, with my patch your "testRawMessageByMailMessageClassConsumer" test should succeed if you do {{exchange.getBody(javax.mail.Message)}}.

      was (Author: rkettelerij):
    @Martin, with my patch your "testRawMessageByMailMessageClassConsumer" test should succeed.
  
> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093-mapMailMessage.patch, CAMEL-4093.diff, CAMEL-4093_with_adapted_unit_test_regarding_MailMessageClass.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Richard Kettelerij (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Kettelerij reassigned CAMEL-4093:
-----------------------------------------

    Assignee: Richard Kettelerij

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4093) s/Mime signed Mails lead to Exceptions in pop3 component

Posted by "Dr. Martin Menzel (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dr. Martin Menzel updated CAMEL-4093:
-------------------------------------

    Description: 
If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.

I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

------------ additional remark -------------

During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).

=> The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  

deliverRawMailMessage

example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true

I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

  was:
If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.

I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

     Issue Type: New Feature  (was: Bug)

> s/Mime signed Mails lead to Exceptions in pop3 component
> --------------------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093.diff
>
>
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055052#comment-13055052 ] 

Claus Ibsen commented on CAMEL-4093:
------------------------------------

You should be able to do this already. There is a Camel MailMessage type which allows you to get access to the javax.mail.Message instance where you can get the raw message.

I have just committed an unit test showing that
http://svn.apache.org/viewvc?rev=1139760&view=rev

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4093) s/Mime signed Mails lead to Exceptions in pop3 component

Posted by "Dr. Martin Menzel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048478#comment-13048478 ] 

Dr. Martin Menzel commented on CAMEL-4093:
------------------------------------------

I try to create a unit test. If you plan to run the test in a CI environment, which mailserver shall I use to run the test against? 

Some of the actual tests use 

store.connect("localhost", 25, "jones", "secret");

Is this ok for my tests too?

> s/Mime signed Mails lead to Exceptions in pop3 component
> --------------------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>             Fix For: 2.8.0, 2.9.0
>
>         Attachments: CAMEL-4093.diff
>
>
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Dr. Martin Menzel (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dr. Martin Menzel updated CAMEL-4093:
-------------------------------------

    Attachment: CAMEL-4093_with_adapted_unit_test_regarding_MailMessageClass.diff

When I understood Claus's comment right, the special MessageType can be used to deliver the mailapi Message Object. 

So to pipe this message over several steps we would have to write our own processor to transform the Message Object to a serialized Type (like String) before deliver this serialized Object to for example a file component. 

In the attached modified unit test you find a example where the Message is multicast to a mock and to a file component. Without an intermediate Processor the proposed type converter mechanism leads to a null pointer exception.

Any comments to my thoughts are welcome.

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093.diff, CAMEL-4093_with_adapted_unit_test_regarding_MailMessageClass.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Richard Kettelerij (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Kettelerij updated CAMEL-4093:
--------------------------------------

    Attachment: CAMEL-4093-mapMailMessage.patch

I've attached a patch containing the 'mapMailMessage' option that Claus suggested. I've used parts of Martin's patch.

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093-mapMailMessage.patch, CAMEL-4093.diff, CAMEL-4093_with_adapted_unit_test_regarding_MailMessageClass.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Dr. Martin Menzel (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dr. Martin Menzel updated CAMEL-4093:
-------------------------------------

    Attachment: CAMEL-4093_with_unit_test.diff

The behavior of the pop3 component without using the patch is not treated as an error in the unit test. Without the patch the mailbody can be loaded in a MimeMessage object but all headers are missing so that signature checks of processors would fail. With the patch the complete message including mail headers is delivered as a mail body.

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Richard Kettelerij (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055101#comment-13055101 ] 

Richard Kettelerij edited comment on CAMEL-4093 at 6/26/11 4:50 PM:
--------------------------------------------------------------------

@Martin, with my patch your "testRawMessageByMailMessageClassConsumer" test should succeed if you do {{exchange.getBody(javax.mail.Message.class)}}.

      was (Author: rkettelerij):
    @Martin, with my patch your "testRawMessageByMailMessageClassConsumer" test should succeed if you do {{exchange.getBody(javax.mail.Message)}}.
  
> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093-mapMailMessage.patch, CAMEL-4093.diff, CAMEL-4093_with_adapted_unit_test_regarding_MailMessageClass.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4093) pop3 component parameter deliverRawMailMessage

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055055#comment-13055055 ] 

Claus Ibsen commented on CAMEL-4093:
------------------------------------

We could maybe introduce a new mapMailMessage option (default true) that determines if Camel should map the raw mail message to headers/bodies etc.

By disabling this option you will just receive the raw mail message which you can access as shown above in that commit.

We have such an option in the JMS component.

> pop3 component parameter deliverRawMailMessage
> ----------------------------------------------
>
>                 Key: CAMEL-4093
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4093
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-mail
>    Affects Versions: 2.7.2
>         Environment: Solaris and Windows
>            Reporter: Dr. Martin Menzel
>            Assignee: Richard Kettelerij
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4093.diff, CAMEL-4093_with_unit_test.diff
>
>
> Old Subject: s/Mime signed Mails lead to Exceptions in pop3 component
> If a s/mime signed Mail is received by the pop3 Mail component a expection is thrown during handling the body of the message. This happens because a different type of body object is delivered by javamail.
> I fixed this issue by introducing a new parameter which makes it possible to deliver the complete mail source in the Camel message body. In this way you are able to handle the content with processors in a very flexiable way.
> ------------ additional remark -------------
> During my preparation of testcases I reduced the complexity of my former project, removed classpath jars just to the basics jars needed to run pop3 retieval. In this situation I don't get the error anymore (for Java DSL and Spring configuration).
> => The included patch is therefore just a new feature which is helpfull if a processor/consumer would like to get the complete mail source instead of just the payload. This can be controlled by a new pop3 component uri parameter  
> deliverRawMailMessage
> example spring  URL: pop3s://camel.test@pop.googlemail.com?password=pazzword&amp;debugMode=true&amp;deliverRawMailMessage=true
> I will deliver a unit test which tests the different behavior without disturbing the normal way of delivering mail content.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira