You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/02 09:54:52 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #5845:
[READY] [feature] Added dashboard read only with new Rho role
codecov-io edited a comment on issue #5845: [READY] [feature] Added dashboard read only with new Rho role
URL: https://github.com/apache/incubator-superset/pull/5845#issuecomment-419846717
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5845?src=pr&el=h1) Report
> Merging [#5845](https://codecov.io/gh/apache/incubator-superset/pull/5845?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/56eac687f8f1d360f68fc78213ade8d298409603?src=pr&el=desc) will **increase** coverage by `8.22%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5845?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5845 +/- ##
==========================================
+ Coverage 65.89% 74.11% +8.22%
==========================================
Files 459 106 -353
Lines 22014 11522 -10492
Branches 2417 0 -2417
==========================================
- Hits 14507 8540 -5967
+ Misses 7386 2982 -4404
+ Partials 121 0 -121
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5845?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `94.04% <100%> (+0.03%)` | :arrow_up: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.91% <100%> (+0.89%)` | :arrow_up: |
| [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `74.8% <91.66%> (+0.83%)` | :arrow_up: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `45.83% <0%> (-20.84%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `87.93% <0%> (-0.18%)` | :arrow_down: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
| [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | | |
| [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | | |
| ... and [348 more](https://codecov.io/gh/apache/incubator-superset/pull/5845/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5845?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5845?src=pr&el=footer). Last update [56eac68...d50f21f](https://codecov.io/gh/apache/incubator-superset/pull/5845?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org