You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/10 06:22:08 UTC
[GitHub] [apisix-website] iamayushdas opened a new pull request #297: fix: darkMode enhanced
iamayushdas opened a new pull request #297:
URL: https://github.com/apache/apisix-website/pull/297
Fixes: #291
Changes:
Dark mode fixed and enhanced
Screenshots of the change:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817304164
> I have got a way to solve your issue, do ask if you are facing any problem.
>
>
>
> If I am correct you are facing problem doing this right ? (GIF below, description changing color from black to white)
>
>
>
> 
>
>
Yup, i need your help buddy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas removed a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas removed a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817087193
@juzhiyuan @nic-chen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817665530
Deploy preview for *apisix* ready!
Built with commit 9d45847aad011efcc926b9bf5a91c28e19d2b282
https://deploy-preview-297--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817303998
I have got a way to solve your issue, do ask if you are facing any problem.
If I am correct you are facing problem doing this right ? (GIF below, description changing color from black to white)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817278136
I am recreating that apisix architecture photo with transparent background. For the better of Dark mode legacy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817753327
> > Something not related to your doing, but some company logos in "Who is using this" section don't have an alpha property, so it looks odd that some have a white background while other don't and they don't mix properly.
>
>
>
> Would fix in #303 cc @1502shivam-singh
I was just doing thatπ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817671694
@juzhiyuan @Yiyiyimu @nic-chen @liuxiran
Completed darkmode for apisix-website :relieved:
here are the changes: (screeshots)
[Help page](https://user-images.githubusercontent.com/40708551/114376504-4edccd80-9ba3-11eb-8907-b0d9af090aef.png)
[Team page](https://user-images.githubusercontent.com/40708551/114376510-500dfa80-9ba3-11eb-9800-801220336b72.png)
[Downloads page](https://user-images.githubusercontent.com/40708551/114376515-513f2780-9ba3-11eb-9317-169bfb1c6397.png)
[Doc page](https://user-images.githubusercontent.com/40708551/114376491-4c7a7380-9ba3-11eb-90a3-aace4161a36d.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817308651
> > > > > I have got a way to solve your issue, do ask if you are facing any problem.
>
> > > > > If I am correct you are facing problem doing this right ? (GIF below, description changing color from black to white)
>
> > > > > 
>
> > > >
>
> > > >
>
> > > > Yup, i need your help buddy
>
> > >
>
> > >
>
> > > The most basic way to do this, that comes to my mind right now is to give the styled components some class and then slide that class property in the customTheme.css with CSS required.
>
> >
>
> > i have given it a try, but didn't worked. lemme do it again thanks bud
>
>
>
> That's how I did it π, how's it not working, check again π
Yep yepπ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817091093
Also it seems you also change some color in the light mode, like the github button, which seems not as good as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817751693
> Something not related to your doing, but some company logos in "Who is using this" section don't have an alpha property, so it looks odd that some have a white background while other don't and they don't mix properly.
Would fix in #303 cc @1502shivam-singh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817114059
@Yiyiyimu @juzhiyuan @nic-chen @gxthrj
How is it now?
[Website change 2](https://user-images.githubusercontent.com/40708551/114266705-4b1b4080-9a15-11eb-9f36-3581053eef0e.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817087223
@juzhiyuan @nic-chen have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817098375
@iamayushdas no π I mean we need more contributors review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817137243
> > @Yiyiyimu @juzhiyuan @nic-chen @gxthrj
>
> > How is it now?
>
> > [Website change 2](https://user-images.githubusercontent.com/40708551/114266705-4b1b4080-9a15-11eb-9f36-3581053eef0e.png)
>
>
>
> Some points -
>
> - Avoid using pure black, like you have used in description section. Hurts eyes when using dark mode, when its actually needed i.e. in dark. Try material design based colors
>
> - Don't grey out the CTA's, like the "View on GitHub" button
>
> - Watch out for the other greyed out buttons like the "subscribe" button. The button and button text contrast is quite low.
>
> - Contrast issues elsewhere in the site
>
>
>
> 
>
>
>
> 
>
>
>
> - Something not related to your doing, but some company logos in "Who is using this" section don't have an alpha property, so it looks odd that some have a white background while other don't and they don't mix properly.
>
>
>
> Fact is, that the images on the home-page are not yet optimized to fit in a dark mode. Like the design image in description section doesn't look like it belongs to this website in dark mode, because of color differences and all. It even looks as if its cropped out uneven, without any space tbh π.
>
>
>
>
Okay then will keep your suggestions in mind in next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817297105
@juzhiyuan @Yiyiyimu @1502shivam-singh after PR attached to issue no - #301 will be merged
we will get true dark mode compatible image that i have promised to create see :grinning:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817297703
> @juzhiyuan @Yiyiyimu @1502shivam-singh
> After collectively going through all your reviews above
>
> 
>
> *Note - tried but unable to figure out how to use styled-components for dark mode via customTheme.css (docusaurus way)
Nice π,
Just one last thing, can you fix the text contrast in the download section and the help section.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817136261
> @Yiyiyimu @juzhiyuan @nic-chen @gxthrj
> How is it now?
> 
Some points -
- Avoid using pure black, like you have used in description section. Hurts eyes when using dark mode, when its actually needed i.e. in dark. Try material design based colors
- Don't grey out the CTA's, like the "View on GitHub" button
- Watch out for the other greyed out buttons like the "subscribe" button. The button and button text contrast is quite low.
- Contrast issues elsewhere in the site


- Something not related to your doing, but some company logos in "Who is using this" section don't have an alpha property, so it looks odd that some have a white background while other don't and they don't mix properly.
Fact is, that the images on the home-page are not yet optimized to fit in a dark mode. Like the design image in description section doesn't look like it belongs to this website in dark mode, because of color differences and all. It even looks as if its cropped out uneven, without any space tbh π.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817753327
> > Something not related to your doing, but some company logos in "Who is using this" section don't have an alpha property, so it looks odd that some have a white background while other don't and they don't mix properly.
>
>
>
> Would fix in #303 cc @1502shivam-singh
I was just doing thatπ btw Thanks @Yiyiyimu for thisπ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817256148
@juzhiyuan @Yiyiyimu @1502shivam-singh
After collectively going through all your reviews above
[Website change 3](https://user-images.githubusercontent.com/40708551/114294237-cedb3880-9aba-11eb-8899-75ac4e9b7598.png)
*Note - tried but unable to figure out how to use styled-components for dark mode via customTheme.css (docusaurus way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #297:
URL: https://github.com/apache/apisix-website/pull/297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817087193
@juzhiyuan @nic-chen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817671694
@juzhiyuan @Yiyiyimu @nic-chen @liuxiran
Completed darkmode for apisix-website :relieved:
here are the changes: (screeshots)
[Help page](https://user-images.githubusercontent.com/40708551/114376504-4edccd80-9ba3-11eb-8907-b0d9af090aef.png)
[Team page](https://user-images.githubusercontent.com/40708551/114376510-500dfa80-9ba3-11eb-9800-801220336b72.png)
[Downloads page](https://user-images.githubusercontent.com/40708551/114376515-513f2780-9ba3-11eb-9317-169bfb1c6397.png)
[Doc page](https://user-images.githubusercontent.com/40708551/114376491-4c7a7380-9ba3-11eb-90a3-aace4161a36d.png)
Waiting eagerly to give gift Dark mode to users and devs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817256148
@juzhiyuan @Yiyiyimu @1502shivam-singh
After collectively going through all your reviews above

*Note - tried but unable to figure out how to use styled-components for dark mode via customTheme.css (docusaurus way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817297105
@juzhiyuan @Yiyiyimu after PR attached to issue no - #301 will be merged
we will get true dark mode compatible image that i have promised to create see :grinning:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817098539
> @iamayushdas no π I mean we need more contributors review.
Oh okayπ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817090748
Post my comments here
> @iamayushdas Nice! For me, I have some other suggestions. Just take it or leave it with your preferences π
>
> 1. It might be a good idea to propose a PR, so we could have a more instinctive view of the actual website rather than screenshots
> 2. For the description part, IMO, we could have a darker background with lighter(whitish) text to be compatible with other parts of the whole website. And still, the background of this part better different from other ones.
> 3. Grayish title is absolutely great, it's the main part of the dark mode. But the problem is it seems too dark right now so the contract between text and background is not clear enough. A example from DuckDuckGo
> 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817100063
@gxthrj @nic-chen need a review on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817671694
@juzhiyuan @Yiyiyimu @nic-chen @liuxiran
Completed darkmode for apisix-website :relieved:
here are the changes: (screeshots)
[Help page](https://user-images.githubusercontent.com/40708551/114376504-4edccd80-9ba3-11eb-8907-b0d9af090aef.png)
[Team page](https://user-images.githubusercontent.com/40708551/114376510-500dfa80-9ba3-11eb-9800-801220336b72.png)
[Downloads page](https://user-images.githubusercontent.com/40708551/114376515-513f2780-9ba3-11eb-9317-169bfb1c6397.png)
[Doc page](https://user-images.githubusercontent.com/40708551/114376491-4c7a7380-9ba3-11eb-90a3-aace4161a36d.png)
Waiting eagerly to gift Dark mode to users and devs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817114059
@Yiyiyimu @juzhiyuan @nic-chen @gxthrj
How is it now?

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817304164
> I have got a way to solve your issue, do ask if you are facing any problem.
>
>
>
> If I am correct you are facing problem doing this right ? (GIF below, description changing color from black to white)
>
>
>
> 
>
>
Yup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817088534
> really dark π how about others?
Is this a positive feedback ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817137243
> > @Yiyiyimu @juzhiyuan @nic-chen @gxthrj
>
> > How is it now?
>
> > 
>
>
>
> Some points -
>
> - Avoid using pure black, like you have used in description section. Hurts eyes when using dark mode, when its actually needed i.e. in dark. Try material design based colors
>
> - Don't grey out the CTA's, like the "View on GitHub" button
>
> - Watch out for the other greyed out buttons like the "subscribe" button. The button and button text contrast is quite low.
>
> - Contrast issues elsewhere in the site
>
>
>
> 
>
>
>
> 
>
>
>
> - Something not related to your doing, but some company logos in "Who is using this" section don't have an alpha property, so it looks odd that some have a white background while other don't and they don't mix properly.
>
>
>
> Fact is, that the images on the home-page are not yet optimized to fit in a dark mode. Like the design image in description section doesn't look like it belongs to this website in dark mode, because of color differences and all. It even looks as if its cropped out uneven, without any space tbh π.
>
>
>
>
Okay then will keep your suggestions in mind in next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817297105
@juzhiyuan @Yiyiyimu @1502shivam-singh after PR attached to issue no - #301 will be merged
we will get true dark mode compatible image that i have promised to create see :grinning:
[Website change 4](https://user-images.githubusercontent.com/40708551/114303646-d74c6700-9aec-11eb-919b-5d7aa36725ff.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817308250
> > > I have got a way to solve your issue, do ask if you are facing any problem.
> > > If I am correct you are facing problem doing this right ? (GIF below, description changing color from black to white)
> > > 
> >
> >
> > Yup, i need your help buddy
>
> The most basic way to do this, that comes to my mind right now is to give the styled components some class and then slide that class property in the customTheme.css with CSS required.
i have given it a try, but didn't worked. lemme do it again thanks bud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817307212
> > I have got a way to solve your issue, do ask if you are facing any problem.
> > If I am correct you are facing problem doing this right ? (GIF below, description changing color from black to white)
> > 
>
> Yup, i need your help buddy
The most basic way to do this, that comes to my mind right now is to give the styled components some class and then slide that class property in the customTheme.css with CSS required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817308478
> > > > I have got a way to solve your issue, do ask if you are facing any problem.
> > > > If I am correct you are facing problem doing this right ? (GIF below, description changing color from black to white)
> > > > 
> > >
> > >
> > > Yup, i need your help buddy
> >
> >
> > The most basic way to do this, that comes to my mind right now is to give the styled components some class and then slide that class property in the customTheme.css with CSS required.
>
> i have given it a try, but didn't worked. lemme do it again thanks bud
That's how I did it π, how's it not working, check again π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817665530
Deploy preview for *apisix* processing.
Building with commit 9d45847aad011efcc926b9bf5a91c28e19d2b282
https://app.netlify.com/sites/apisix/deploys/6074180db6827100081c1e8b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817098632
> Also it seems you also change some color in the light mode, like the github button, which seems not as good as before.
Let me acquire what you saidπ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817088124
really dark π how about others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #297: fix: darkMode enhanced
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817298134
> > @juzhiyuan @Yiyiyimu @1502shivam-singh
>
> > After collectively going through all your reviews above
>
> >
>
> > 
>
> >
>
> > *Note - tried but unable to figure out how to use styled-components for dark mode via customTheme.css (docusaurus way)
>
>
>
> Nice π,
>
> Just one last thing, can you fix the text contrast in the download section and the help section.
>
>
>
> 
>
>
Right now i am figuring out how to deal with that download page styled-components because its not handling in docusaurus way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org