You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Tyhoning (via GitHub)" <gi...@apache.org> on 2025/04/18 04:22:48 UTC
[PR] Add support for GaussDB database type [flink-connector-jdbc]
Tyhoning opened a new pull request, #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162
Add support for GaussDB database type, So you can use Flink jdbc to write to the gaussdb database now。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "Tyhoning (via GitHub)" <gi...@apache.org>.
Tyhoning commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2061964009
##########
flink-connector-jdbc-gaussdb/pom.xml:
##########
@@ -0,0 +1,148 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-parent</artifactId>
+ <version>4.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>flink-connector-jdbc-gaussdb</artifactId>
+ <name>Flink : Connectors : JDBC : GaussDB</name>
+
+ <packaging>jar</packaging>
+
+ <properties>
+ <gaussdb.version>506.0.0.b058</gaussdb.version>
+ </properties>
+
+ <dependencies>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-core</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-core</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-common</artifactId>
+ <version>${flink.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-api-java-bridge</artifactId>
+ <version>${flink.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-test-utils</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- Gaussdb -->
+ <dependency>
+ <groupId>com.huaweicloud.gaussdb</groupId>
+ <artifactId>gaussdbjdbc</artifactId>
+ <version>506.0.0.b058</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>com.huaweicloud.gaussdb</groupId>
+ <artifactId>gaussdbjdbc</artifactId>
+ <version>506.0.0.b058</version>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- Assertions test dependencies -->
+ <dependency>
+ <groupId>org.assertj</groupId>
+ <artifactId>assertj-core</artifactId>
+ <version>${assertj.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>jdbc</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>postgresql</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ <version>42.7.3</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-core</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <!-- <dependency>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ <version>42.7.3</version>
+ <scope>test</scope>
+ </dependency>-->
+
+ <!-- Gaussdb tests -->
+<!-- <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>gaussdb</artifactId>
+ <scope>test</scope>
+ </dependency>-->
Review Comment:
Its Removed it ,thanks for you review。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37737] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #162: [FLINK-37737] Add support for GaussDB database type
URL: https://github.com/apache/flink-connector-jdbc/pull/162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37737] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "Tyhoning (via GitHub)" <gi...@apache.org>.
Tyhoning commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2151238598
##########
pom.xml:
##########
@@ -53,6 +53,7 @@ under the License.
<module>flink-connector-jdbc-postgres</module>
<module>flink-connector-jdbc-sqlserver</module>
<module>flink-connector-jdbc-trino</module>
+ <module>flink-connector-jdbc-gaussdb</module>
Review Comment:
OK ,done. pls see https://github.com/apache/flink-connector-jdbc/pull/162/commits/e8510efef5143b642c94668617ce6b0e26c5fa93 .Thanks for you review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37737] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#issuecomment-3591042142
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "Tyhoning (via GitHub)" <gi...@apache.org>.
Tyhoning commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2061965272
##########
flink-connector-jdbc-gaussdb/pom.xml:
##########
@@ -0,0 +1,135 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
To remain consistent with the community, thanks for you review。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37737] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "Tyhoning (via GitHub)" <gi...@apache.org>.
Tyhoning commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2197225733
##########
flink-connector-jdbc-gaussdb/src/main/java/org/apache/flink/connector/jdbc/gaussdb/database/dialect/CompatibleGaussdbDialect.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.jdbc.gaussdb.database.dialect;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.types.logical.RowType;
+
+import java.util.Optional;
+
+/**
+ * JDBC dialect for GaussDB compatible databases.
+ *
+ * <p>Notes: The source code is based on CompatiblePostgresDialect.
+ */
+@PublicEvolving
+public abstract class CompatibleGaussdbDialect extends GaussdbDialect {
Review Comment:
Done， pls see 1c8d5ed0f6b696bb8dd876db643ed9e123eb2a23。Thanks for your review !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "eskabetxe (via GitHub)" <gi...@apache.org>.
eskabetxe commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2059797560
##########
flink-connector-jdbc-gaussdb/pom.xml:
##########
@@ -0,0 +1,135 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-parent</artifactId>
+ <version>4.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>flink-connector-jdbc-gaussdb</artifactId>
Review Comment:
ou also need to integrate this module into the architecture module to ensure proper validation.
##########
flink-connector-jdbc-gaussdb/pom.xml:
##########
@@ -0,0 +1,135 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-parent</artifactId>
+ <version>4.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>flink-connector-jdbc-gaussdb</artifactId>
Review Comment:
you also need to integrate this module into the architecture module to ensure proper validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "Tyhoning (via GitHub)" <gi...@apache.org>.
Tyhoning commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2061964906
##########
flink-connector-jdbc-gaussdb/src/test/java/org/apache/flink/connector/jdbc/gaussdb/testutils/GaussDBContainer.java:
##########
@@ -0,0 +1,162 @@
+package org.apache.flink.connector.jdbc.gaussdb.testutils;
Review Comment:
The license header has been added,thanks for you review。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37737] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#issuecomment-3695581290
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37737] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "Tyhoning (via GitHub)" <gi...@apache.org>.
Tyhoning commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2151232890
##########
flink-connector-jdbc-gaussdb/src/main/java/org/apache/flink/connector/jdbc/gaussdb/database/dialect/CompatibleGaussdbDialect.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.jdbc.gaussdb.database.dialect;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.types.logical.RowType;
+
+import java.util.Optional;
+
+/**
+ * JDBC dialect for GaussDB compatible databases.
+ *
+ * <p>Notes: The source code is based on CompatiblePostgresDialect.
+ */
+@PublicEvolving
+public abstract class CompatibleGaussdbDialect extends GaussdbDialect {
Review Comment:
Thank you very much for your review !
In fact, GaussDB has its own dialect and is not compatible with Postgresql, such as the update syntax.In the future, they will have more incompatibilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2051881164
##########
flink-connector-jdbc-gaussdb/pom.xml:
##########
@@ -0,0 +1,148 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-parent</artifactId>
+ <version>4.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>flink-connector-jdbc-gaussdb</artifactId>
+ <name>Flink : Connectors : JDBC : GaussDB</name>
+
+ <packaging>jar</packaging>
+
+ <properties>
+ <gaussdb.version>506.0.0.b058</gaussdb.version>
+ </properties>
+
+ <dependencies>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-core</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-core</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-common</artifactId>
+ <version>${flink.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-api-java-bridge</artifactId>
+ <version>${flink.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-test-utils</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- Gaussdb -->
+ <dependency>
+ <groupId>com.huaweicloud.gaussdb</groupId>
+ <artifactId>gaussdbjdbc</artifactId>
+ <version>506.0.0.b058</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>com.huaweicloud.gaussdb</groupId>
+ <artifactId>gaussdbjdbc</artifactId>
+ <version>506.0.0.b058</version>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- Assertions test dependencies -->
+ <dependency>
+ <groupId>org.assertj</groupId>
+ <artifactId>assertj-core</artifactId>
+ <version>${assertj.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>jdbc</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>postgresql</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ <version>42.7.3</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-core</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <!-- <dependency>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ <version>42.7.3</version>
+ <scope>test</scope>
+ </dependency>-->
+
+ <!-- Gaussdb tests -->
+<!-- <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>gaussdb</artifactId>
+ <scope>test</scope>
+ </dependency>-->
Review Comment:
Remove not used code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "macdoor (via GitHub)" <gi...@apache.org>.
macdoor commented on PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#issuecomment-2829649841
@Tyhoning
```
[ERROR] Could not execute SQL statement. Reason:
java.lang.UnsupportedOperationException: Doesn't support Gaussdb type 'int1' yet
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "Tyhoning (via GitHub)" <gi...@apache.org>.
Tyhoning commented on PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#issuecomment-2833306512
Click here to join Jira discuss。
https://issues.apache.org/jira/browse/FLINK-37737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2052341651
##########
flink-connector-jdbc-gaussdb/src/test/java/org/apache/flink/connector/jdbc/gaussdb/testutils/GaussDBContainer.java:
##########
@@ -0,0 +1,162 @@
+package org.apache.flink.connector.jdbc.gaussdb.testutils;
Review Comment:
Add license header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37737] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "eskabetxe (via GitHub)" <gi...@apache.org>.
eskabetxe commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2141133681
##########
flink-connector-jdbc-gaussdb/src/main/java/org/apache/flink/connector/jdbc/gaussdb/database/dialect/CompatibleGaussdbDialect.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.jdbc.gaussdb.database.dialect;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.table.types.logical.RowType;
+
+import java.util.Optional;
+
+/**
+ * JDBC dialect for GaussDB compatible databases.
+ *
+ * <p>Notes: The source code is based on CompatiblePostgresDialect.
+ */
+@PublicEvolving
+public abstract class CompatibleGaussdbDialect extends GaussdbDialect {
Review Comment:
Why this compatible class??
Are GaussDB a postgres syntax compatible database? If yes the GaussDBDialect should extend the CompatiblePostgresDialect, but we dont need to create this classes..
##########
flink-connector-jdbc-gaussdb/pom.xml:
##########
@@ -0,0 +1,117 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-parent</artifactId>
+ <version>4.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>flink-connector-jdbc-gaussdb</artifactId>
+ <name>Flink : Connectors : JDBC : GaussDB</name>
+
+ <packaging>jar</packaging>
+
+ <properties>
+ <gaussdb.version>506.0.0.b058-jdk7</gaussdb.version>
+ </properties>
+
+ <dependencies>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-core</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-core</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-common</artifactId>
+ <version>${flink.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-api-java-bridge</artifactId>
+ <version>${flink.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-test-utils</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- Gaussdb -->
+ <dependency>
+ <groupId>com.huaweicloud.gaussdb</groupId>
+ <artifactId>gaussdbjdbc</artifactId>
+ <version>506.0.0.b058-jdk7</version>
+<!-- <scope>provided</scope>-->
Review Comment:
this should be uncomment
##########
pom.xml:
##########
@@ -53,6 +53,7 @@ under the License.
<module>flink-connector-jdbc-postgres</module>
<module>flink-connector-jdbc-sqlserver</module>
<module>flink-connector-jdbc-trino</module>
+ <module>flink-connector-jdbc-gaussdb</module>
Review Comment:
can we add this ordered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "Tyhoning (via GitHub)" <gi...@apache.org>.
Tyhoning commented on PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#issuecomment-2832934375
> @Tyhoning
>
> ```
> [ERROR] Could not execute SQL statement. Reason:
> java.lang.UnsupportedOperationException: Doesn't support Gaussdb type 'int1' yet
> ```
Pls check you files type , used 'int4' instead of 'int1'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#issuecomment-2814506344
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37737] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "Tyhoning (via GitHub)" <gi...@apache.org>.
Tyhoning commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2151238256
##########
flink-connector-jdbc-gaussdb/pom.xml:
##########
@@ -0,0 +1,117 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-parent</artifactId>
+ <version>4.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>flink-connector-jdbc-gaussdb</artifactId>
+ <name>Flink : Connectors : JDBC : GaussDB</name>
+
+ <packaging>jar</packaging>
+
+ <properties>
+ <gaussdb.version>506.0.0.b058-jdk7</gaussdb.version>
+ </properties>
+
+ <dependencies>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-core</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-jdbc-core</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-common</artifactId>
+ <version>${flink.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-api-java-bridge</artifactId>
+ <version>${flink.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-test-utils</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- Gaussdb -->
+ <dependency>
+ <groupId>com.huaweicloud.gaussdb</groupId>
+ <artifactId>gaussdbjdbc</artifactId>
+ <version>506.0.0.b058-jdk7</version>
+<!-- <scope>provided</scope>-->
Review Comment:
OK ,done. pls see https://github.com/apache/flink-connector-jdbc/pull/162/commits/e8510efef5143b642c94668617ce6b0e26c5fa93 .Thanks for you review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 commented on code in PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2052340905
##########
flink-connector-jdbc-gaussdb/pom.xml:
##########
@@ -0,0 +1,135 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
Add license header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37737] Add support for GaussDB database type [flink-connector-jdbc]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 commented on PR #162:
URL: https://github.com/apache/flink-connector-jdbc/pull/162#issuecomment-3190983364
> Some minor comments left..
>
> Is GaussDD a postgres syntax compatible? if yes please use CrateDB as reference.
>
> @1996fanrui can you run CI/CD please
GaussDB was developed from PostgreSQL but now is not compatible with PostgreSQL and will not in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org