You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Robert Munteanu (JIRA)" <ji...@apache.org> on 2015/02/19 15:15:11 UTC
[jira] [Updated] (SLING-4438) Don't execute duplicate or
out-of-order commands
[ https://issues.apache.org/jira/browse/SLING-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Munteanu updated SLING-4438:
-----------------------------------
Description:
Content sync operations work through commands created on demand by SlingLaunchpadBehaviour.
Right now the order is ad-hoc and there is no guarantee that duplicate or redundant commands are not executed. Some examples:
- Trying to add an sling:Folder resource twice since it seems both the directory and the .content.xml file as changed
- Deleting a path attempts to delete the parent _and_ all children nodes
We also have some akwardness to make sure that SLING-3741 works as expected, see https://svn.apache.org/r1660881 .
The fix would be to have generate the commands, pass them to a provider-specific command queue, which insures that the above cases are handled as expected and then execute the commands in the order returned by the queue.
A nice side-effect is that we can rely on the number of events generated, and can use that for wait for events to settle in tests, instead of hard-coding wait times.
was:
Content sync operations work through commands created on demand by SlingLaunchpadBehaviour.
Right now the order is ad-hoc and there is no guarantee that duplicate or redundant commands are not executed. Some examples:
- Trying to add an sling:Folder resource twice since it seems both the directory and the .content.xml file as changed
- Deleting a path attempts to delete the parent _and_ all children nodes
We also have some akwardness to make sure that SLING-3741 works as expected, see https://svn.apache.org/r1660881 .
The fix would be to have generate the commands, pass them to a provider-specific command queue, which insures that the above cases are handled as expected and then execute the commands in the order returned by the queue.
> Don't execute duplicate or out-of-order commands
> ------------------------------------------------
>
> Key: SLING-4438
> URL: https://issues.apache.org/jira/browse/SLING-4438
> Project: Sling
> Issue Type: Bug
> Components: IDE
> Affects Versions: Sling Eclipse IDE 1.0.4
> Reporter: Robert Munteanu
> Priority: Critical
> Fix For: Sling Eclipse IDE 1.1.0
>
>
> Content sync operations work through commands created on demand by SlingLaunchpadBehaviour.
> Right now the order is ad-hoc and there is no guarantee that duplicate or redundant commands are not executed. Some examples:
> - Trying to add an sling:Folder resource twice since it seems both the directory and the .content.xml file as changed
> - Deleting a path attempts to delete the parent _and_ all children nodes
> We also have some akwardness to make sure that SLING-3741 works as expected, see https://svn.apache.org/r1660881 .
> The fix would be to have generate the commands, pass them to a provider-specific command queue, which insures that the above cases are handled as expected and then execute the commands in the order returned by the queue.
> A nice side-effect is that we can rely on the number of events generated, and can use that for wait for events to settle in tests, instead of hard-coding wait times.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)