You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Baodi Shi <ba...@apache.org> on 2023/06/29 09:45:39 UTC
Change workflows run rule for outside collaborators of Go client
Hi, all.
For now, non-committer PRs for Go clients do not run CI automatically and
require to committer approval every time.
Can we modify this rule? Only first-time contributors need committer
approval.
Who has permission to modify it?
Thanks,
Baodi Shi
Re: Change workflows run rule for outside collaborators of Go client
Posted by Baodi Shi <ba...@apache.org>.
Hi,@tison, @Jarek Potiuk <ja...@potiuk.com>
Thanks for your explanation, I got it.
Thanks,
Baodi Shi
On Jun 29, 2023 at 18:17:24, Jarek Potiuk <ja...@potiuk.com> wrote:
> There is this policy in place that handles it:
> https://infra.apache.org/github-actions-policy.html
>
> It was announced a few months ago and several projects that saw that
> "approve all" policy as unsustainable for their community got the policy
> changed.
>
> Example ticket from Airflow:
> https://issues.apache.org/jira/projects/INFRA/issues/INFRA-24200 with
> justifications why we needed to reverse it and confirmation that we are
> aware of the dangers mentioned in the policy and monitor if there is no
> abuse happening.
>
> Projects that have a strong desire to use the “only require approval
>
> first time” option should communicate that, explaining their reasons, in a
> Jira ticket for Infra.
>
>
> On Thu, Jun 29, 2023 at 11:55 AM tison <wa...@gmail.com> wrote:
>
> I remember it's an apache org-wise configuration. cc users@infra.a.o.
>
>
> For now, non-committers can use personal CI tech like[1] to unblock CI
>
> verifications. And if anyone continues contributing and meets trouble with
>
> this inconvenience, I suggest we should nominate the contributor as
>
> committer to help he/she make contributions.
>
>
> Best,
>
> tison.
>
>
> [1] https://pulsar.apache.org/contribute/personal-ci/
>
>
>
> Baodi Shi <ba...@apache.org> 于2023年6月29日周四 17:45写道：
>
>
> > Hi, all.
>
> >
>
> > For now, non-committer PRs for Go clients do not run CI automatically and
>
> > require to committer approval every time.
>
> >
>
> > Can we modify this rule? Only first-time contributors need committer
>
> > approval.
>
> >
>
> > Who has permission to modify it?
>
> >
>
> > Thanks,
>
> > Baodi Shi
>
> >
>
>
>
Re: Change workflows run rule for outside collaborators of Go client
Posted by Jarek Potiuk <ja...@potiuk.com>.
There is this policy in place that handles it:
https://infra.apache.org/github-actions-policy.html
It was announced a few months ago and several projects that saw that
"approve all" policy as unsustainable for their community got the policy
changed.
Example ticket from Airflow:
https://issues.apache.org/jira/projects/INFRA/issues/INFRA-24200 with
justifications why we needed to reverse it and confirmation that we are
aware of the dangers mentioned in the policy and monitor if there is no
abuse happening.
> Projects that have a strong desire to use the “only require approval
first time” option should communicate that, explaining their reasons, in a
Jira ticket for Infra.
On Thu, Jun 29, 2023 at 11:55 AM tison <wa...@gmail.com> wrote:
> I remember it's an apache org-wise configuration. cc users@infra.a.o.
>
> For now, non-committers can use personal CI tech like[1] to unblock CI
> verifications. And if anyone continues contributing and meets trouble with
> this inconvenience, I suggest we should nominate the contributor as
> committer to help he/she make contributions.
>
> Best,
> tison.
>
> [1] https://pulsar.apache.org/contribute/personal-ci/
>
>
> Baodi Shi <ba...@apache.org> 于2023年6月29日周四 17:45写道：
>
>> Hi, all.
>>
>> For now, non-committer PRs for Go clients do not run CI automatically and
>> require to committer approval every time.
>>
>> Can we modify this rule? Only first-time contributors need committer
>> approval.
>>
>> Who has permission to modify it?
>>
>> Thanks,
>> Baodi Shi
>>
>
Re: Change workflows run rule for outside collaborators of Go client
Posted by tison <wa...@gmail.com>.
I remember it's an apache org-wise configuration. cc users@infra.a.o.
For now, non-committers can use personal CI tech like[1] to unblock CI
verifications. And if anyone continues contributing and meets trouble with
this inconvenience, I suggest we should nominate the contributor as
committer to help he/she make contributions.
Best,
tison.
[1] https://pulsar.apache.org/contribute/personal-ci/
Baodi Shi <ba...@apache.org> 于2023年6月29日周四 17:45写道：
> Hi, all.
>
> For now, non-committer PRs for Go clients do not run CI automatically and
> require to committer approval every time.
>
> Can we modify this rule? Only first-time contributors need committer
> approval.
>
> Who has permission to modify it?
>
> Thanks,
> Baodi Shi
>