You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/05 08:44:25 UTC
[GitHub] [doris] HappenLee opened a new pull request, #15650: [Refactor](pipeline) refactor the code of channel buffer limit and change the default value
HappenLee opened a new pull request, #15650:
URL: https://github.com/apache/doris/pull/15650
## Problem summary
After do the change: tpch q9 cost time 7.6s -> 7s
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15650: [Refactor](pipeline) refactor the code of channel buffer limit and change the default value
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15650:
URL: https://github.com/apache/doris/pull/15650#discussion_r1062459152
##########
be/test/vec/runtime/vdata_stream_test.cpp:
##########
@@ -130,11 +130,10 @@ TEST_F(VDataStreamTest, BasicTest) {
TUniqueId uid;
PlanNodeId nid = 1;
int num_senders = 1;
- int buffer_size = 1024 * 1024;
RuntimeProfile profile("profile");
bool is_merge = false;
std::shared_ptr<QueryStatisticsRecvr> statistics = std::make_shared<QueryStatisticsRecvr>();
- auto recv = _instance.create_recvr(&runtime_stat, row_desc, uid, nid, num_senders, buffer_size,
+ auto recv = _instance.create_recvr(&runtime_stat, row_desc, uid, nid, num_senders,
Review Comment:
warning: '_instance' is a private member of 'doris::vectorized::VDataStreamTest' [clang-diagnostic-error]
```cpp
auto recv = _instance.create_recvr(&runtime_stat, row_desc, uid, nid, num_senders,
^
```
**be/test/vec/runtime/vdata_stream_test.cpp:103:** declared private here
```cpp
VDataStreamMgr _instance;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15650: [Refactor](pipeline) refactor the code of channel buffer limit and change the default value
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15650:
URL: https://github.com/apache/doris/pull/15650#discussion_r1063056457
##########
be/test/vec/runtime/vdata_stream_test.cpp:
##########
@@ -130,12 +130,11 @@ TEST_F(VDataStreamTest, BasicTest) {
TUniqueId uid;
PlanNodeId nid = 1;
int num_senders = 1;
- int buffer_size = 1024 * 1024;
RuntimeProfile profile("profile");
bool is_merge = false;
std::shared_ptr<QueryStatisticsRecvr> statistics = std::make_shared<QueryStatisticsRecvr>();
- auto recv = _instance.create_recvr(&runtime_stat, row_desc, uid, nid, num_senders, buffer_size,
- &profile, is_merge, statistics);
+ auto recv = _instance.create_recvr(&runtime_stat, row_desc, uid, nid, num_senders, &profile,
Review Comment:
warning: '_instance' is a private member of 'doris::vectorized::VDataStreamTest' [clang-diagnostic-error]
```cpp
auto recv = _instance.create_recvr(&runtime_stat, row_desc, uid, nid, num_senders, &profile,
^
```
**be/test/vec/runtime/vdata_stream_test.cpp:103:** declared private here
```cpp
VDataStreamMgr _instance;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15650: [Refactor](pipeline) refactor the code of channel buffer limit and change the default value
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15650:
URL: https://github.com/apache/doris/pull/15650#issuecomment-1372183006
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.64 seconds
load time: 471 seconds
storage size: 17122098496 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230105125657_clickbench_pr_74247.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #15650: [Refactor](pipeline) refactor the code of channel buffer limit and change the default value
Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #15650:
URL: https://github.com/apache/doris/pull/15650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15650: [Refactor](pipeline) refactor the code of channel buffer limit and change the default value
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15650:
URL: https://github.com/apache/doris/pull/15650#issuecomment-1371938018
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15650: [Refactor](pipeline) refactor the code of channel buffer limit and change the default value
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15650:
URL: https://github.com/apache/doris/pull/15650#issuecomment-1371933628
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org