[GitHub] [arrow] nevi-me commented on pull request #8548: ARROW-8421: [Rust] [Parquet] Merge in-progress writer & reader

[GitBox <gi...@apache.org>]

nevi-me commented on pull request #8548:
URL: https://github.com/apache/arrow/pull/8548#issuecomment-718370707


   > There was probably some mis-understanding during the call yesterday, but I was expecting this to be a pull request and approved by another committer _before being merged_. This merge IMO did not follow our review practice and did not gave time to other committers to go through it.
   
   Apologies Jorge,
   
   The intention was to bring in the changes into master, on the rebuttable presumption that they've been reviewed already.
   We don't have a lot of review bandwidth, so I wasn't expecting anyone to review the commits again, as we also wouldn't easily change them (maybe except the last commit with a `git commit --amend`.
   
   After creating the PR, I noticed that the other merge options have been disabled in the UI (we can only squash now), so the aim of being able to use the UI to merge this was defeated; and so I rebased and pushed from my end.
   
   I've gone through your questions around arraydata equality, so I'll have a look at what you've done on #8541, and I can prioritise any follow-up work needed to cover what might still be outstanding.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org