You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "younsl (via GitHub)" <gi...@apache.org> on 2026/10/08 14:37:52 UTC
[PR] feat(helm): add priorityClassName value [superset-kubernetes-operator]
younsl opened a new pull request, #420:
URL: https://github.com/apache/superset-kubernetes-operator/pull/420
## Summary
Add an optional [priorityClassName](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/) value for the operator manager pod. Today the chart has no way to set a PriorityClass on its own Deployment, and extraManifests cannot patch it, so clusters that rank platform controllers above workloads cannot protect the operator from preemption or schedule it ahead of tenant pods. The value defaults to null, so the rendered manifest is unchanged and pods keep the cluster default priority.
## Details
- The Deployment template renders priorityClassName only when the value is set, next to the other scheduling fields (nodeSelector, affinity, tolerations, topologySpreadConstraints).
- The default follows the null convention for optional strings from #394. [values.schema.json](https://helm.sh/docs/topics/charts/#schema-files) accepts a string or null, and an explicit empty string still renders nothing.
- The values description links the [Kubernetes pod priority docs](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/). The chart README is regenerated with [helm-docs](https://github.com/norwoodj/helm-docs).
- The full-options test values set the key so the values coverage check passes, and the full-options snapshot gains the field. Two focused tests cover the default (field absent) and a configured value.
- The changelog entry is added under Unreleased.
<details>
<summary>Verification</summary>
- [helm-unittest](https://github.com/helm-unittest/helm-unittest): 31 tests and 26 snapshots pass.
- helm lint strict and [kubeconform](https://github.com/yannh/kubeconform) strict pass for the default and full-options values (10 and 15 resources, all valid).
- make helm-lint, make helm-values-covered, make lint-md, and make codegen (no diff) pass.
- kind cluster (Kubernetes 1.37): with an existing PriorityClass, the manager pod is admitted with that class and its resolved priority value (100000). With a nonexistent class, the ReplicaSet fails pod creation with "no PriorityClass with name missing-class was found", as expected from the Priority admission plugin.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(helm): add priorityClassName value [superset-kubernetes-operator]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #420:
URL: https://github.com/apache/superset-kubernetes-operator/pull/420#discussion_r4220846779
##########
charts/superset-operator/templates/deployment.yaml:
##########
@@ -149,3 +149,6 @@ spec:
topologySpreadConstraints:
{{- toYaml . | nindent 8 }}
{{- end }}
+ {{- with .Values.priorityClassName }}
+ priorityClassName: {{ . }}
Review Comment:
nit: we could maybe quote this, just in case:
```suggestion
priorityClassName: {{ . | quote }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(helm): add priorityClassName value [superset-kubernetes-operator]
Posted by "younsl (via GitHub)" <gi...@apache.org>.
younsl commented on PR #420:
URL: https://github.com/apache/superset-kubernetes-operator/pull/420#issuecomment-6063430375
@villebro Thanks for the review! I applied the quote suggestion in 1eb3525 and resolved the thread. This is ready to merge. The CI workflows on the new commit are waiting for maintainer approval to run, so could you approve them before merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(helm): add priorityClassName value [superset-kubernetes-operator]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #420:
URL: https://github.com/apache/superset-kubernetes-operator/pull/420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(helm): add priorityClassName value [superset-kubernetes-operator]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #420:
URL: https://github.com/apache/superset-kubernetes-operator/pull/420#issuecomment-6063369632
## [Codecov](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/420?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.15%. Comparing base ([`a6e412a`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/a6e412a64dc6f6615a810624e8836f108f01a839?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4159924`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/415992496d5f127e22dadd9e552f7f91975f5309?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/420?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org