You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/06/18 02:32:23 UTC
[GitHub] zeppelin pull request #1041: Get note revision of note - git repo
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1041
Get note revision of note - git repo
### What is this PR for?
This PR implements the backend of git storage layer for `get(noteId, revision)`, so that you can get the note of certain revision. It doesn't provide frontend api yet, which is future work.
### What type of PR is it?
Improvement
### Todos
* [ ] - implement `get` of GitNotebookRepo
* [ ] - add tests
### What is the Jira issue?
N/A
### How should this be tested?
two tests for `get` function should pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/git-get-note-revision-of-note
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1041.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1041
----
commit c91dff08c255efd69b9fde5068c36b7a3ad74dd2
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-06-16T23:53:58Z
change field name: revId -> id
commit 01d16463048fb65551e716af2da540d109347f1f
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-06-16T23:55:07Z
basic impl of get specific version of note
commit d71b4036069422a70bdd2242b7bf3755182d7bd6
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-06-17T00:23:32Z
add edge case fail test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1041: Get note revision of note - git repo
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1041
rebased from master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1041: Get note revision of note - git repo
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1041
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1041: Get note revision of note - git repo
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1041
Looks awesome to me, CI failure tacked under [ZEPPELIN-862](https://issues.apache.org/jira/browse/ZEPPELIN-862)
```
23:25:52,963 INFO org.apache.zeppelin.socket.NotebookServer:1193 - Job 20160621-232552_848972577 is finished
Spark version detected 1.6.1
23:25:53,036 INFO org.apache.zeppelin.notebook.Paragraph:252 - run paragraph 20160621-232553_1646750103 using r org.apache.zeppelin.interpreter.LazyOpenInterpreter@65953319
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated
```
It's not related to current changes, so merging if there is no more discusion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1041: Get note revision of note - git repo
Posted by onkarshedge <gi...@git.apache.org>.
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/1041
@khalidhuseynov will this be merged soon ? Currently I have extended the `Rev` class for my Ipfs Revision. If this is merged I won't have to extend.
```java
private class IpfsRevision extends NotebookRepoVersioned.Rev {
private String commitMessage;
IpfsRevision(String name, int time, String message) {
super(name, time);
commitMessage = message;
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1041: Get note revision of note - git repo
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1041
Looks great to me, sans rebased on master and a minor javadoc issue above.
I think it's good to merge as soon as those are addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---