You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/03/15 22:11:32 UTC

Review Request 32088: DRILL-2467: Fix "datatype" to "datetype" for test Hive DATE column.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32088/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Repository: drill-git


Description
-------

Renamed DATE column from "datatype" to "datetype" to match pattern of others (e.g., "booleantype" for BOOLEAN column).


Diffs
-----

  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 0758791 

Diff: https://reviews.apache.org/r/32088/diff/


Testing
-------

Ran new tests for JDBC metadata fixes (DRILL-2420--related) and existing tests.


Thanks,

Daniel Barclay


Re: Review Request 32088: DRILL-2467: Fix "datatype" to "datetype" for test Hive DATE column.

Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32088/#review76797
-----------------------------------------------------------

Ship it!


Ship It!

- Mehant Baid


On March 15, 2015, 9:11 p.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32088/
> -----------------------------------------------------------
> 
> (Updated March 15, 2015, 9:11 p.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Renamed DATE column from "datatype" to "datetype" to match pattern of others (e.g., "booleantype" for BOOLEAN column).
> 
> 
> Diffs
> -----
> 
>   contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 0758791 
> 
> Diff: https://reviews.apache.org/r/32088/diff/
> 
> 
> Testing
> -------
> 
> Ran new tests for JDBC metadata fixes (DRILL-2420--related) and existing tests.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>