You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Aleksey Shipilev (JIRA)" <ji...@apache.org> on 2008/08/04 12:33:44 UTC
[jira] Created: (HARMONY-5930) [classlib][pack200][performance]
IcBands.getRelevantIcTuples rewrite
[classlib][pack200][performance] IcBands.getRelevantIcTuples rewrite
--------------------------------------------------------------------
Key: HARMONY-5930
URL: https://issues.apache.org/jira/browse/HARMONY-5930
Project: Harmony
Issue Type: Improvement
Components: Classlib
Environment: Latest pack200
Reporter: Aleksey Shipilev
This issue is dedicated for IcBands.getRelevantIcTuples rewrite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5930) [classlib][pack200][performance]
IcBands.getRelevantIcTuples rewrite
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-5930:
--------------------------------------
Attachment: pack200-relevantIcTuples-v3.patch
pack200-relevantIcTuples-v3.patch
V2 + bugfix
I had confused outerClass<->icTuple mapping with thisClass<->icTuple. That was the reason of the test failure.
This patch passes short JUnit tests now (complete SQL tests included there).
Gives +8% to unpacking scenario.
> [classlib][pack200][performance] IcBands.getRelevantIcTuples rewrite
> --------------------------------------------------------------------
>
> Key: HARMONY-5930
> URL: https://issues.apache.org/jira/browse/HARMONY-5930
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: Latest pack200
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Attachments: pack200-relevantIcTuples-v2.patch, pack200-relevantIcTuples-v3.patch
>
>
> This issue is dedicated for IcBands.getRelevantIcTuples rewrite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5930) [classlib][pack200][performance]
IcBands.getRelevantIcTuples rewrite
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev closed HARMONY-5930.
-------------------------------------
Estimated Complexity: Moderate (was: Novice)
Thanks here too, Sian.
Applied ok.
> [classlib][pack200][performance] IcBands.getRelevantIcTuples rewrite
> --------------------------------------------------------------------
>
> Key: HARMONY-5930
> URL: https://issues.apache.org/jira/browse/HARMONY-5930
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: Latest pack200
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Fix For: 5.0M8
>
> Attachments: pack200-relevantIcTuples-v2.patch, pack200-relevantIcTuples-v3.patch
>
>
> This issue is dedicated for IcBands.getRelevantIcTuples rewrite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5930) [classlib][pack200][performance]
IcBands.getRelevantIcTuples rewrite
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622375#action_12622375 ]
Aleksey Shipilev commented on HARMONY-5930:
-------------------------------------------
So far I can't see what am I doing wrong in the patch. I haven't run long tests yet, as it need more time than I have for now. I will review this issue later.
Does it the only class that fail?
> [classlib][pack200][performance] IcBands.getRelevantIcTuples rewrite
> --------------------------------------------------------------------
>
> Key: HARMONY-5930
> URL: https://issues.apache.org/jira/browse/HARMONY-5930
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: Latest pack200
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Attachments: pack200-relevantIcTuples-v2.patch
>
>
> This issue is dedicated for IcBands.getRelevantIcTuples rewrite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5930) [classlib][pack200][performance]
IcBands.getRelevantIcTuples rewrite
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622232#action_12622232 ]
Sian January commented on HARMONY-5930:
---------------------------------------
With this patch, some of the inner class data seems to be being missed out. E.g. after applying the patch and running javap on the class file for org.apache.harmony.sql.tests.javax.sql.rowset.serial.SerialArrayTest, which should have 5 inner classes, the InnerClass attribute only lists 3.
> [classlib][pack200][performance] IcBands.getRelevantIcTuples rewrite
> --------------------------------------------------------------------
>
> Key: HARMONY-5930
> URL: https://issues.apache.org/jira/browse/HARMONY-5930
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: Latest pack200
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Attachments: pack200-relevantIcTuples-v2.patch
>
>
> This issue is dedicated for IcBands.getRelevantIcTuples rewrite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5930) [classlib][pack200][performance]
IcBands.getRelevantIcTuples rewrite
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-5930:
--------------------------------------
Attachment: pack200-relevantIcTuples-v2.patch
pack200-relevantIcTuples-v2.patch
- rewrites IcBands.getRelevantIcTuples()
- creates the map <class name, IcTuple> to save string comparisons
- saves IcTuple index to make optimized sort
- incorporates CCP.allClasses() into IcBands.getRelevantIcTuples() to save one wasted list
- modifies tests accordingly
Passes JUnit tests for pack200.
Gives +10% to unpacking scenario.
> [classlib][pack200][performance] IcBands.getRelevantIcTuples rewrite
> --------------------------------------------------------------------
>
> Key: HARMONY-5930
> URL: https://issues.apache.org/jira/browse/HARMONY-5930
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: Latest pack200
> Reporter: Aleksey Shipilev
> Attachments: pack200-relevantIcTuples-v2.patch
>
>
> This issue is dedicated for IcBands.getRelevantIcTuples rewrite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5930) [classlib][pack200][performance]
IcBands.getRelevantIcTuples rewrite
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January reassigned HARMONY-5930:
-------------------------------------
Assignee: Sian January
> [classlib][pack200][performance] IcBands.getRelevantIcTuples rewrite
> --------------------------------------------------------------------
>
> Key: HARMONY-5930
> URL: https://issues.apache.org/jira/browse/HARMONY-5930
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: Latest pack200
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Attachments: pack200-relevantIcTuples-v2.patch
>
>
> This issue is dedicated for IcBands.getRelevantIcTuples rewrite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5930) [classlib][pack200][performance]
IcBands.getRelevantIcTuples rewrite
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January resolved HARMONY-5930.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M8
Applied v3 patch in r689413. Please check that it was applied as you expected.
> [classlib][pack200][performance] IcBands.getRelevantIcTuples rewrite
> --------------------------------------------------------------------
>
> Key: HARMONY-5930
> URL: https://issues.apache.org/jira/browse/HARMONY-5930
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: Latest pack200
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Fix For: 5.0M8
>
> Attachments: pack200-relevantIcTuples-v2.patch, pack200-relevantIcTuples-v3.patch
>
>
> This issue is dedicated for IcBands.getRelevantIcTuples rewrite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.