You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "robertwb (via GitHub)" <gi...@apache.org> on 2023/02/06 18:08:29 UTC
[GitHub] [beam] robertwb opened a new pull request, #25351: Better batching for higher fixed costs.
robertwb opened a new pull request, #25351:
URL: https://github.com/apache/beam/pull/25351
Make Python's BatchElements more aggressive batching in some cases, capping at 10 second rather than 1 second batches by default and excluding fixed cost in this computation.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #25351: Better batching for higher fixed costs.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on code in PR #25351:
URL: https://github.com/apache/beam/pull/25351#discussion_r1097896596
##########
sdks/python/apache_beam/transforms/util.py:
##########
@@ -502,8 +502,11 @@ def _calculate_next_batch_size(self):
target = self._max_batch_size
if self._target_batch_duration_secs:
- # Solution to a + b*x = self._target_batch_duration_secs.
- target = min(target, (self._target_batch_duration_secs - a) / b)
+ # Solution to b*x = self._target_batch_duration_secs.
+ # We ignore the fixed cost in this computation as it has negligeabel
Review Comment:
In that case we still won't batch (much or at all). That's the problem with absolute limits (but it felt too risky of a backwards incompatible change to remove it altogether). But it increases the range that the more general overhead calculation takes precedence instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iindyk commented on a diff in pull request #25351: Better batching for higher fixed costs.
Posted by "iindyk (via GitHub)" <gi...@apache.org>.
iindyk commented on code in PR #25351:
URL: https://github.com/apache/beam/pull/25351#discussion_r1097807904
##########
sdks/python/apache_beam/transforms/util.py:
##########
@@ -502,8 +502,11 @@ def _calculate_next_batch_size(self):
target = self._max_batch_size
if self._target_batch_duration_secs:
- # Solution to a + b*x = self._target_batch_duration_secs.
- target = min(target, (self._target_batch_duration_secs - a) / b)
+ # Solution to b*x = self._target_batch_duration_secs.
+ # We ignore the fixed cost in this computation as it has negligeabel
Review Comment:
I think this is wrong: what if the element overhead and fixed cost are both large?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #25351: Better batching for higher fixed costs.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #25351:
URL: https://github.com/apache/beam/pull/25351#issuecomment-1419561170
Failures due to `fatal: write error: No space left on device`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25351: Better batching for higher fixed costs.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25351:
URL: https://github.com/apache/beam/pull/25351#issuecomment-1419611761
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @tvalentyn for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #25351: Better batching for higher fixed costs.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #25351:
URL: https://github.com/apache/beam/pull/25351#issuecomment-1421244343
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #25351: Better batching for higher fixed costs.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25351:
URL: https://github.com/apache/beam/pull/25351#issuecomment-1421264434
# [Codecov](https://codecov.io/gh/apache/beam/pull/25351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#25351](https://codecov.io/gh/apache/beam/pull/25351?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d6d8880) into [master](https://codecov.io/gh/apache/beam/commit/bb582d8db12344e1aba5a269cf50fd0ddc2af374?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb582d8) will **not change** coverage.
> The diff coverage is `84.61%`.
```diff
@@ Coverage Diff @@
## master #25351 +/- ##
=======================================
Coverage 72.95% 72.95%
=======================================
Files 745 745
Lines 99174 99174
=======================================
Hits 72353 72353
Misses 25455 25455
Partials 1366 1366
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/25351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/25351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `96.28% <84.61%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #25351: Better batching for higher fixed costs.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #25351:
URL: https://github.com/apache/beam/pull/25351#issuecomment-1419531382
R: @iindyk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb merged pull request #25351: Better batching for higher fixed costs.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb merged PR #25351:
URL: https://github.com/apache/beam/pull/25351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org