[jira] [Commented] (HADOOP-9159) FileSystem class should override .equals(Object)

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525585#comment-14525585 ] 

Hadoop QA commented on HADOOP-9159:
-----------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 31s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 2 new or modified test files. |
| {color:green}+1{color} | javac |   7m 27s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 36s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   1m  4s | The applied patch generated  1 new checkstyle issues (total was 142, now 142). |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 3  line(s) that end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 39s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
| {color:red}-1{color} | common tests |  23m 33s | Tests failed in hadoop-common. |
| | |  60m 23s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.fs.TestHarFileSystem |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12561804/HADOOP-9159.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6ae2a0d |
| checkstyle |  https://builds.apache.org/job/PreCommit-HADOOP-Build/6438/artifact/patchprocess/diffcheckstylehadoop-common.txt |
| whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/6438/artifact/patchprocess/whitespace.txt |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6438/artifact/patchprocess/testrun_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6438/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6438/console |


This message was automatically generated.

> FileSystem class should override .equals(Object)
> ------------------------------------------------
>
>                 Key: HADOOP-9159
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9159
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 1.1.1, 3.0.0
>            Reporter: Thejas M Nair
>            Assignee: Brandon Li
>         Attachments: HADOOP-9159.patch, HADOOP-9159.patch
>
>
> The FileSystem class has a notion of equality, based on the uri. The class should override .equal(Object) so that it returns true if FileSystem objects are logically same. 
> This is useful when FileSystem cache is disabled, as FileSystem.get(..) will return new object each time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)