You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Vyacheslav Daradur <da...@gmail.com> on 2017/03/16 07:08:16 UTC

ignite-4823 - ready for review (SpringCache#putIfAbsent - wrong implementation)

Hello everyone.

Please review changes: *https://issues.apache.org/jira/browse/IGNITE-4823
<https://issues.apache.org/jira/browse/IGNITE-4823>*

I found this when I worked on an another issue.

If I'm not mistaken it's wrong implementation.

--
Best Regards, Vyacheslav

Re: ignite-4823 - ready for review (SpringCache#putIfAbsent - wrong implementation)

Posted by Valentin Kulichenko <va...@gmail.com>.
Hi Vyacheslav,

I reviewed and merged you changes to master. Thanks for the contribution!

-Val

On Fri, Mar 17, 2017 at 12:06 AM, Vyacheslav Daradur <da...@gmail.com>
wrote:

> Valentin, ok, thank you.
>
> 2017-03-16 18:39 GMT+03:00 Valentin Kulichenko <
> valentin.kulichenko@gmail.com>:
>
> > Vyacheslav,
> >
> > I will review and merge in nearest time.
> >
> > -Val
> >
> > On Thu, Mar 16, 2017 at 8:08 AM, Vyacheslav Daradur <daradurvs@gmail.com
> >
> > wrote:
> >
> > > Hello everyone.
> > >
> > > Please review changes: *https://issues.apache.org/
> > jira/browse/IGNITE-4823
> > > <https://issues.apache.org/jira/browse/IGNITE-4823>*
> > >
> > > I found this when I worked on an another issue.
> > >
> > > If I'm not mistaken it's wrong implementation.
> > >
> > > --
> > > Best Regards, Vyacheslav
> > >
> >
>
>
>
> --
> Best Regards, Vyacheslav
>

Re: ignite-4823 - ready for review (SpringCache#putIfAbsent - wrong implementation)

Posted by Vyacheslav Daradur <da...@gmail.com>.
Valentin, ok, thank you.

2017-03-16 18:39 GMT+03:00 Valentin Kulichenko <
valentin.kulichenko@gmail.com>:

> Vyacheslav,
>
> I will review and merge in nearest time.
>
> -Val
>
> On Thu, Mar 16, 2017 at 8:08 AM, Vyacheslav Daradur <da...@gmail.com>
> wrote:
>
> > Hello everyone.
> >
> > Please review changes: *https://issues.apache.org/
> jira/browse/IGNITE-4823
> > <https://issues.apache.org/jira/browse/IGNITE-4823>*
> >
> > I found this when I worked on an another issue.
> >
> > If I'm not mistaken it's wrong implementation.
> >
> > --
> > Best Regards, Vyacheslav
> >
>



-- 
Best Regards, Vyacheslav

Re: ignite-4823 - ready for review (SpringCache#putIfAbsent - wrong implementation)

Posted by Valentin Kulichenko <va...@gmail.com>.
Vyacheslav,

I will review and merge in nearest time.

-Val

On Thu, Mar 16, 2017 at 8:08 AM, Vyacheslav Daradur <da...@gmail.com>
wrote:

> Hello everyone.
>
> Please review changes: *https://issues.apache.org/jira/browse/IGNITE-4823
> <https://issues.apache.org/jira/browse/IGNITE-4823>*
>
> I found this when I worked on an another issue.
>
> If I'm not mistaken it's wrong implementation.
>
> --
> Best Regards, Vyacheslav
>