You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/29 05:16:00 UTC

[GitHub] [pulsar] hangc0276 opened a new pull request #11141: add parameter to control publish message check policy frequency

hangc0276 opened a new pull request #11141:
URL: https://github.com/apache/pulsar/pull/11141


   ### Motivation
   In current `isExceedMaximumMessageSize` implementation, it get topic policy and compare maxMessageSize value.
   However, for each message to publish, it should call isExceedMaximumMessageSize once, which cost too much resources.
   
   ### Modifiction
   1. add `maxMessageSizeCheckIntervalInSeconds` parameter to control maxMessageSize refresh frequency
   2. reduce getTopicPolicies call frequency to reduce resources cost.
   3. add test to cover this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #11141: add parameter to control publish message check policy frequency

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11141:
URL: https://github.com/apache/pulsar/pull/11141


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11141: add parameter to control publish message check policy frequency

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11141:
URL: https://github.com/apache/pulsar/pull/11141#discussion_r660443479



##########
File path: conf/broker.conf
##########
@@ -487,6 +487,10 @@ maxMessagePublishBufferSizeInMB=
 # Use 0 or negative number to disable the check
 retentionCheckIntervalInSeconds=120
 
+# Check between intervals to see if max message size in topic policies has been updated.
+# Default is 60s

Review comment:
       Do you mean this?
   
   ```suggestion
   # Control the frequency of checking the max message size in the topic policy. 
   # The default interval is 60 seconds.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11141: add parameter to control publish message check policy frequency

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11141:
URL: https://github.com/apache/pulsar/pull/11141#discussion_r660443479



##########
File path: conf/broker.conf
##########
@@ -487,6 +487,10 @@ maxMessagePublishBufferSizeInMB=
 # Use 0 or negative number to disable the check
 retentionCheckIntervalInSeconds=120
 
+# Check between intervals to see if max message size in topic policies has been updated.
+# Default is 60s

Review comment:
       Do you mean this
   
   ```suggestion
   # Control the frequency of checking the max message size in the topic policy. 
   # The default interval is 60 seconds.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11141: add parameter to control publish message check policy frequency

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11141:
URL: https://github.com/apache/pulsar/pull/11141#discussion_r660443479



##########
File path: conf/broker.conf
##########
@@ -487,6 +487,10 @@ maxMessagePublishBufferSizeInMB=
 # Use 0 or negative number to disable the check
 retentionCheckIntervalInSeconds=120
 
+# Check between intervals to see if max message size in topic policies has been updated.
+# Default is 60s

Review comment:
       Do you mean this
   
   ```suggestion
   # Control the frequency of checking the max message size in the topic policy. 
   # The default interval is 60 seconds.
   ```

##########
File path: conf/broker.conf
##########
@@ -487,6 +487,10 @@ maxMessagePublishBufferSizeInMB=
 # Use 0 or negative number to disable the check
 retentionCheckIntervalInSeconds=120
 
+# Check between intervals to see if max message size in topic policies has been updated.
+# Default is 60s

Review comment:
       Do you mean this?
   
   ```suggestion
   # Control the frequency of checking the max message size in the topic policy. 
   # The default interval is 60 seconds.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org