You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/01/31 07:36:53 UTC
svn commit: r1852573 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java
Author: tilman
Date: Thu Jan 31 07:36:53 2019
New Revision: 1852573
URL: http://svn.apache.org/viewvc?rev=1852573&view=rev
Log:
PDFBOX-4452: avoid ClassCastException
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java?rev=1852573&r1=1852572&r2=1852573&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java Thu Jan 31 07:36:53 2019
@@ -29,6 +29,8 @@ import org.apache.pdfbox.pdmodel.common.
import java.util.ArrayList;
import java.util.List;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
/**
* The page tree, which defines the ordering of pages in the document in an efficient manner.
@@ -37,6 +39,7 @@ import java.util.List;
*/
public class PDPageTree implements COSObjectable, Iterable<PDPage>
{
+ private static final Log LOG = LogFactory.getLog(PDPageTree.class);
private final COSDictionary root;
private final PDDocument document; // optional
@@ -132,7 +135,7 @@ public class PDPageTree implements COSOb
{
List<COSDictionary> result = new ArrayList<>();
- COSArray kids = (COSArray)node.getDictionaryObject(COSName.KIDS);
+ COSArray kids = node.getCOSArray(COSName.KIDS);
if (kids == null)
{
// probably a malformed PDF
@@ -141,7 +144,15 @@ public class PDPageTree implements COSOb
for (int i = 0, size = kids.size(); i < size; i++)
{
- result.add((COSDictionary)kids.getObject(i));
+ COSBase base = kids.getObject(i);
+ if (base instanceof COSDictionary)
+ {
+ result.add((COSDictionary) base);
+ }
+ else
+ {
+ LOG.warn("COSDictionary expected, but got " + base.getClass().getSimpleName());
+ }
}
return result;