You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/02 21:30:21 UTC

[GitHub] [incubator-nuttx] diegoherranz opened a new pull request #2462: drivers/led/ws2812: fix comments

diegoherranz opened a new pull request #2462:
URL: https://github.com/apache/incubator-nuttx/pull/2462


   ## Summary
   Complete or improve some explanations and fix some typos
   I believe @btashton wrote this in the first place. Could you double-check whether the stuff I've fixed makes sense?
   Thanks!
   
   ## Impact
   Just comments
   
   ## Testing
   Just comments
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton merged pull request #2462: drivers/led/ws2812: fix comments

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2462:
URL: https://github.com/apache/incubator-nuttx/pull/2462


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] diegoherranz commented on pull request #2462: drivers/led/ws2812: fix comments

Posted by GitBox <gi...@apache.org>.
diegoherranz commented on pull request #2462:
URL: https://github.com/apache/incubator-nuttx/pull/2462#issuecomment-739494812


   > Were you able to use this driver?
   
   I'm starting to use it on an STM32 board and it seems to be working. I may contribute some board support for it.
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2462: drivers/led/ws2812: fix comments

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2462:
URL: https://github.com/apache/incubator-nuttx/pull/2462#issuecomment-737673130


   @diegoherranz Thanks for cleaning up my comments. I added this driver in the middle of a lot of changes and I guess I got a little sloppy.
   
   Were you able to use this driver?  I have only tested it so far on the nrf52 (that's also why I only added the two supported clock rates that work), but have plans to use it on a board with ATSAMD51.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org