You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2020/03/31 17:18:40 UTC
[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15620
Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
......................................................................
Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
This will be used to fix IMPALA-9540 "Impala Shell sends duplicate
"Host" headers in http mode". Many http servers will not accept an http
request that has multiple copies of the Host header. Remove the
extraneous call which adds an unnecessary header.
TESTING:
I built the toolchain using jenkins. I built impala with the new
toolchain, ran all Impala end-to-end tests, and tested that IMPALA-9540
is fixed.
Change-Id: If5fbeeba4c55423128733ec15a3dbabf2b6ac8a6
---
M buildall.sh
A source/thrift/thrift-0.9.3-patches/0008-remove-duplicated-host-header.patch
2 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/20/15620/1
--
To view, visit http://gerrit.cloudera.org:8080/15620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5fbeeba4c55423128733ec15a3dbabf2b6ac8a6
Gerrit-Change-Number: 15620
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15620 )
Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5fbeeba4c55423128733ec15a3dbabf2b6ac8a6
Gerrit-Change-Number: 15620
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 19:20:53 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15620 )
Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5fbeeba4c55423128733ec15a3dbabf2b6ac8a6
Gerrit-Change-Number: 15620
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 19:02:16 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15620 )
Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
......................................................................
Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.
This will be used to fix IMPALA-9540 "Impala Shell sends duplicate
"Host" headers in http mode". Many http servers will not accept an http
request that has multiple copies of the Host header. Remove the
extraneous call which adds an unnecessary header.
TESTING:
I built the toolchain using jenkins. I built impala with the new
toolchain, ran all Impala end-to-end tests, and tested that IMPALA-9540
is fixed.
Change-Id: If5fbeeba4c55423128733ec15a3dbabf2b6ac8a6
Reviewed-on: http://gerrit.cloudera.org:8080/15620
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Andrew Sherman <as...@cloudera.com>
---
M buildall.sh
A source/thrift/thrift-0.9.3-patches/0008-remove-duplicated-host-header.patch
2 files changed, 28 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Andrew Sherman: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If5fbeeba4c55423128733ec15a3dbabf2b6ac8a6
Gerrit-Change-Number: 15620
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>