You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/11/19 19:43:45 UTC
[GitHub] [incubator-druid] suneet-amp opened a new pull request #8909:
Optimize CachingLocalSegmentAllocator#getSequenceName
suneet-amp opened a new pull request #8909: Optimize CachingLocalSegmentAllocator#getSequenceName
URL: https://github.com/apache/incubator-druid/pull/8909
Fixes #8904
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/incubator-druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
Replace StringUtils#format with string addition to generate the sequence
name for an interval and partition. This is faster because format uses a
Matcher under the covers to replace the string format with the variables.
There is likely a performance gain here because this function is called for
every row in InputSourceProcessor#process
<hr>
This PR has:
- [x] been self-reviewed.
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org