You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/09 17:47:04 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #330:
HDDS-2693. HddsVolume mixes ChunkLayOutVersion and DataNodeLayoutVersion
adoroszlai opened a new pull request #330: HDDS-2693. HddsVolume mixes ChunkLayOutVersion and DataNodeLayoutVersion
URL: https://github.com/apache/hadoop-ozone/pull/330
## What changes were proposed in this pull request?
`HddsVolume` [initializes `layoutVersion` using latest `ChunkLayOutVersion`](https://github.com/apache/hadoop-ozone/blob/1d56bc244995e857b842f62d3d1e544ee100bbc1/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java#L268). But when writing the same info to file, it [verifies `layoutVersion` matches the latest `DataNodeLayoutVersion`](https://github.com/apache/hadoop-ozone/blob/1d56bc244995e857b842f62d3d1e544ee100bbc1/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java#L292-L293). To satisfy the condition `ChunkLayOutVersion` and `DataNodeLayoutVersion` have to be in sync, which means only one of them is necessary. I think the intention was to use `DataNodeLayoutVersion` in both cases, as `ChunkLayOutVersion` is for key-value container internal structure.
https://issues.apache.org/jira/browse/HDDS-2693
## How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/340156676
Currently no test validates this change, since both `ChunkLayOutVersion` and `DataNodeLayoutVersion` are at version 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org