You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2012/11/06 07:02:12 UTC

[jira] [Created] (HIVE-3675) NaN does not work correctly for round(n)

Namit Jain created HIVE-3675:
--------------------------------

             Summary: NaN does not work correctly for round(n)
                 Key: HIVE-3675
                 URL: https://issues.apache.org/jira/browse/HIVE-3675
             Project: Hive
          Issue Type: Bug
          Components: Query Processor
            Reporter: Namit Jain
            Assignee: Namit Jain
             Fix For: 0.10.0


It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3675:
-----------------------------

    Attachment: hive.3675.2.patch
    
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491349#comment-13491349 ] 

Namit Jain commented on HIVE-3675:
----------------------------------

https://reviews.facebook.net/D6507
                
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492167#comment-13492167 ] 

Kevin Wilfong commented on HIVE-3675:
-------------------------------------

comment on diff
                
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493345#comment-13493345 ] 

Kevin Wilfong commented on HIVE-3675:
-------------------------------------

+1
                
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch, hive.3675.3.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493827#comment-13493827 ] 

Hudson commented on HIVE-3675:
------------------------------

Integrated in Hive-trunk-h0.21 #1784 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1784/])
    HIVE-3675. NaN does not work correctly for round(n). (njain via kevinwilfong) (Revision 1407320)

     Result = FAILURE
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407320
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java
* /hive/trunk/ql/src/test/queries/clientpositive/udf_round_2.q
* /hive/trunk/ql/src/test/results/clientpositive/udf4.q.out
* /hive/trunk/ql/src/test/results/clientpositive/udf_round.q.out
* /hive/trunk/ql/src/test/results/clientpositive/udf_round_2.q.out

                
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch, hive.3675.3.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3675:
-----------------------------

    Status: Patch Available  (was: Open)
    
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-3675:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed, thanks Namit.
                
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch, hive.3675.3.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3675:
-----------------------------

    Attachment: hive.3675.3.patch
    
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch, hive.3675.3.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Mark Grover (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493000#comment-13493000 ] 

Mark Grover commented on HIVE-3675:
-----------------------------------

+1

                
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch, hive.3675.3.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-3675:
--------------------------------

    Status: Open  (was: Patch Available)
    
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3675:
-----------------------------

    Attachment: hive.3675.1.patch
    
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3675:
-----------------------------

    Status: Patch Available  (was: Open)

added tests as per comments
                
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch, hive.3675.3.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3675) NaN does not work correctly for round(n)

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494505#comment-13494505 ] 

Hudson commented on HIVE-3675:
------------------------------

Integrated in Hive-trunk-h0.21 #1787 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1787/])
    HIVE-3695. TestParse breaks due to HIVE-3675. (njain via kevinwilfong) (Revision 1407558)

     Result = FAILURE
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407558
Files : 
* /hive/trunk/ql/src/test/results/compiler/plan/udf4.q.xml

                
> NaN does not work correctly for round(n)
> ----------------------------------------
>
>                 Key: HIVE-3675
>                 URL: https://issues.apache.org/jira/browse/HIVE-3675
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3675.1.patch, hive.3675.2.patch, hive.3675.3.patch
>
>
> It works correctly for round(n, d)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira