svn commit: r1573350 - /subversion/trunk/subversion/libsvn_fs_x/string_table.c

[st...@apache.org]

Author: stefan2
Date: Sun Mar  2 19:54:26 2014
New Revision: 1573350

URL: http://svn.apache.org/r1573350
Log:
Fix "uninitialized memory access" warning in valgrind.

* subversion/libsvn_fs_x/string_table.c
  (create_table): Make sure that even the padding area gets set the a
                  defined state and fix the docstring mess.

Found by: philip

Modified:
    subversion/trunk/subversion/libsvn_fs_x/string_table.c

Modified: subversion/trunk/subversion/libsvn_fs_x/string_table.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_x/string_table.c?rev=1573350&r1=1573349&r2=1573350&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_x/string_table.c (original)
+++ subversion/trunk/subversion/libsvn_fs_x/string_table.c Sun Mar  2 19:54:26 2014
@@ -441,9 +441,10 @@ create_table(string_sub_table_t *target,
       string->data = apr_pstrmemdup(pool, string->data, string->len);
     }
 
-  data->len += PADDING; /* there a few extra bytes at then of the buffer
-                           that we want to keep */
+  data->len += PADDING; /* add a few extra bytes at the end of the buffer
+                           that we want to keep valid for chunky access */
   assert(data->len < data->blocksize);
+  memset(data->data + data->len - PADDING, 0, PADDING);
 
   target->data = apr_pmemdup(pool, data->data, data->len);
   target->data_size = data->len;