You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/10/28 15:14:27 UTC

[GitHub] spark pull request #19595: [SPARK-22379][PYTHON] Reduce duplication setUpCla...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/19595

    [SPARK-22379][PYTHON] Reduce duplication setUpClass and tearDownClass in PySpark SQL tests

    ## What changes were proposed in this pull request?
    
    This PR propose to add `ReusedSQLTestCase` which deduplicate `setUpClass` and  `tearDownClass` in `sql/tests.py`.
    
    ## How was this patch tested?
    
    Jenkins tests and manual tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark reduce-dupe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19595
    
----
commit 145ee4a0b4db074f2ce67a3eb2ccca89584f3737
Author: hyukjinkwon <gu...@gmail.com>
Date:   2017-10-28T13:52:37Z

    Reduce duplication setUpClass and tearDownClass in PySpark SQL tests

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19595
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #19595: [SPARK-22379][PYTHON] Reduce duplication setUpCla...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/19595


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19595
  
    cc @ueshin, could you take a look please when you have some time?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19595
  
    **[Test build #83169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83169/testReport)** for PR 19595 at commit [`145ee4a`](https://github.com/apache/spark/commit/145ee4a0b4db074f2ce67a3eb2ccca89584f3737).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19595
  
    **[Test build #83169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83169/testReport)** for PR 19595 at commit [`145ee4a`](https://github.com/apache/spark/commit/145ee4a0b4db074f2ce67a3eb2ccca89584f3737).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `class ReusedSQLTestCase(ReusedPySparkTestCase):`
      * `class SQLTests(ReusedSQLTestCase):`
      * `class SQLTests2(ReusedSQLTestCase):`
      * `class ArrowTests(ReusedSQLTestCase):`
      * `class VectorizedUDFTests(ReusedSQLTestCase):`
      * `class GroupbyApplyTests(ReusedSQLTestCase):`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19595
  
    Thank you @ueshin.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on the issue:

    https://github.com/apache/spark/pull/19595
  
    Thanks! merging to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19595
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83169/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19595: [SPARK-22379][PYTHON] Reduce duplication setUpClass and ...

Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on the issue:

    https://github.com/apache/spark/pull/19595
  
    LGTM.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org