Re: Legacy support for HornetQ

[Martyn Taylor <mt...@redhat.com>]

Quick update on where we are with this.

The old message property keys (and values) i.e. the ones starting with 
"HQ" have been completely removed from the code base and are no longer 
used in the Artemis Core protocol.  These keys have been replaced with 
"AMQ" equivalents.  This work was done as part of: 
https://issues.apache.org/jira/browse/ACTIVEMQ6-97?jql=project%20%3D%20ACTIVEMQ6 
and removes completely any notion of the HornetQ protocol in the core 
server and clients.

A separate protocol module has been created that speaks the HornetQ 
protocol for compatibility with the legacy HornetQ clients.  The 
protocol module can be enabled or disabled by dropping the protocol jar 
on the class path (in the same way that other Artemis protocol modules 
work such as AMQP, STOMP and OPENWIRE).  This work was completed as part 
of: 
https://issues.apache.org/jira/browse/ACTIVEMQ6-100?jql=project%20%3D%20ACTIVEMQ6. 
The implementation is  simplistic in that it consists simply of a 
message interceptor that translates HornetQ messages to/from Artemis Core.

You can expect to see something like this when booting the server with 
the HornetQ protocol jar on the class path:

13:29:42,450 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: Protocol module found: [artemis-server]. Adding protocol support for: CORE
13:29:42,451 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: Protocol module found: [artemis-amqp-protocol]. Adding protocol support for: AMQP
13:29:42,451 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: Protocol module found: [artemis-stomp-protocol]. Adding protocol support for: STOMP
13:29:42,452 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: Protocol module found: [artemis-openwire-protocol]. Adding protocol support for: OPENWIRE
13:29:42,454 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: Protocol module found: [artemis-hornetq-protocol]. Adding protocol support for: HORNETQ
13:29:42,674 INFO  [org.apache.activemq.artemis.core.server] AMQ221020: Started Acceptor at localhost:61616 for protocols [CORE,AMQP,STOMP,HORNETQ,OPENWIRE]


Regards
Martyn

On 14/04/15 19:39, Bruce Snyder wrote:
> Very good point, Dan. Agreed.
>
> Bruce
>
> On Tue, Apr 14, 2015 at 12:07 PM, Daniel Kulp <dk...@apache.org> wrote:
>
>> It’s one thing to “support” the old keys and another thing entirely to
>> make that the default and only option for developers to use right now.   If
>> I download the new release from Apache (having never been a HornetQ user)
>> and start writing apps and such, I SHOULD be using AMQ* keys and
>> properties, not HQ* keys.   Thus, I think the patch needs to do something
>> like:
>>
>> private static final SimpleString AMQ_PROPNAME = new SimpleString("_AMQ_”);
>> @Deprecated
>> private static final SimpleString HQ_PROPNAME = new SimpleString("_HQ_");
>>
>> and update the code to handle both at this point with plans to remove the
>> HQ_ stuff at some point in the future.
>>
>> Does that make sense?
>>
>> Dan
>>
>>
>>> On Apr 14, 2015, at 12:47 PM, Bruce Snyder <br...@gmail.com>
>> wrote:
>>> I'm currently at ApacheCon working with Hiram and Clebert and I have
>>> learned that the HornetQ project is now considered a legacy project --
>> the
>>> code is no longer maintained as the open source project HornetQ. The
>>> expectation is to migrate the HornetQ user base to the ActiveMQ
>> community.
>>> We (the ActiveMQ community) still need to draft a plan of action for
>> steps
>>> to take with the HornetQ code donation, and I think that this could be
>> one
>>> of the things that is identified in that plan to help merge the two
>>> communities. When combining communities in this manner, the goals of the
>>> merger cannot be achieved without some level of compromise and I see this
>>> is as a minor compromise. Therefore, I see no issue with providing
>> backward
>>> compatibility because it is a minor level of effort and yet it helps to
>>> provide a migration path for users of HornetQ (the HornetQ community) to
>>> make use of ActiveMQ <codename>.
>>>
>>> Bruce
>>>
>>>
>>> On Tue, Apr 14, 2015 at 11:30 AM, Tracy Snell <ts...@gmail.com> wrote:
>>>
>>>> https://issues.apache.org/jira/browse/ACTIVEMQ6-97 <
>>>> https://issues.apache.org/jira/browse/ACTIVEMQ6-97> in the comments
>>>> indicates that AMQ6 needs to provide legacy support for HornetQ. This
>> is a
>>>> surprise to me and I haven’t seen anything where this was mentioned as
>> part
>>>> of the plan (and it’s entirely possible I just missed it). So I’m just
>>>> wanting clarification, with the HornetQ donation is ActiveMQ now
>> required
>>>> to provide legacy support for HornetQ clients?
>>>>
>>>>
>>>
>>> --
>>> perl -e 'print
>>> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );'
>>>
>>> ActiveMQ in Action: http://bit.ly/2je6cQ
>>> Blog: http://bruceblog.org/
>>> Twitter: http://twitter.com/brucesnyder
>> --
>> Daniel Kulp
>> dkulp@apache.org - http://dankulp.com/blog
>> Talend Community Coder - http://coders.talend.com
>>
>>
>