You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "keriharris (via GitHub)" <gi...@apache.org> on 2025/11/26 17:32:38 UTC
[PR] Fix Pinot JDBC driver metadata version retrieval [pinot]
keriharris opened a new pull request, #17275:
URL: https://github.com/apache/pinot/pull/17275
The Pinot JDBC driver implements the `getDriverMajorVersion` and `getDriverMinorVersion` methods using `Spring.split`:
```java
@Override
public int getDriverMajorVersion() {
return Integer.parseInt(DRIVER_VERSION.split(".")[0]);
}
@Override
public int getDriverMinorVersion() {
return Integer.parseInt(DRIVER_VERSION.split(".")[1]);
}
```
`String.split` takes an argument representing a regex. The dot ('.') character needs to be escaped, otherwise it represents any character leading to `String.split` returning an empty array. This causes the above methods to throw an exception:
```
java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
at org.apache.pinot.client.PinotConnectionMetaData.getDriverMajorVersion(PinotConnectionMetaData.java:90)
at org.apache.pinot.client.PinotConnectionTest.getMetaDataTest(PinotConnectionTest.java:64)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix Pinot JDBC driver metadata version retrieval [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17275:
URL: https://github.com/apache/pinot/pull/17275#issuecomment-3583240360
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/17275?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.59%. Comparing base ([`d78b39b`](https://app.codecov.io/gh/apache/pinot/commit/d78b39b6ca850d9aa2d50f4c47a9a92a1c8a4745?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dcdb3ba`](https://app.codecov.io/gh/apache/pinot/commit/dcdb3bab3d96602a3342de66b338b9c2ef9ebf48?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (d78b39b) and HEAD (dcdb3ba). Click for more details.
>
> <details><summary>HEAD has 36 uploads less than BASE</summary>
>
>| Flag | BASE (d78b39b) | HEAD (dcdb3ba) |
>|------|------|------|
>|unittests1|2|1|
>|unittests|4|1|
>|java-11|5|0|
>|temurin|10|1|
>|java-21|5|1|
>|unittests2|2|0|
>|integration|6|0|
>|integration2|2|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17275 +/- ##
============================================
- Coverage 63.24% 55.59% -7.65%
+ Complexity 1432 701 -731
============================================
Files 3133 2446 -687
Lines 185904 137600 -48304
Branches 28401 21885 -6516
============================================
- Hits 117568 76494 -41074
+ Misses 59277 54685 -4592
+ Partials 9059 6421 -2638
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.59% <ø> (-7.62%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.59% <ø> (-7.65%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.59% <ø> (-7.65%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.59% <ø> (-0.03%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/17275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/17275?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Fix Pinot JDBC driver metadata version retrieval [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya merged PR #17275:
URL: https://github.com/apache/pinot/pull/17275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org