You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/13 01:33:49 UTC
[GitHub] [shardingsphere] wenweibin opened a new pull request #8149: Format input parameters for msql visitor functions
wenweibin opened a new pull request #8149:
URL: https://github.com/apache/shardingsphere/pull/8149
Fixes #8143 .
Changes proposed in this pull request:
- Format input parameters in `MySQLFormatSQLVisitor.java`
- Format input parameters in `MySQLDDLStatementSQLVisitor.java`
- Format input parameters in `MySQLStatementSQLVisitor.java`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wenweibin commented on a change in pull request #8149: Format input parameters for MySQL and Oracle visitor functions
Posted by GitBox <gi...@apache.org>.
wenweibin commented on a change in pull request #8149:
URL: https://github.com/apache/shardingsphere/pull/8149#discussion_r522825718
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/impl/OracleStatementSQLVisitor.java
##########
@@ -106,14 +107,14 @@
*/
@Getter(AccessLevel.PROTECTED)
public abstract class OracleStatementSQLVisitor extends OracleStatementBaseVisitor<ASTNode> {
-
Review comment:
ok,I will add them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on a change in pull request #8149: Format input parameters for MySQL and Oracle visitor functions
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #8149:
URL: https://github.com/apache/shardingsphere/pull/8149#discussion_r522813379
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/impl/OracleStatementSQLVisitor.java
##########
@@ -106,14 +107,14 @@
*/
@Getter(AccessLevel.PROTECTED)
public abstract class OracleStatementSQLVisitor extends OracleStatementBaseVisitor<ASTNode> {
-
Review comment:
keep four blank
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #8149: Format input parameters for MySQL and Oracle visitor functions
Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #8149:
URL: https://github.com/apache/shardingsphere/pull/8149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #8149: Format input parameters for MySQL and Oracle visitor functions
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #8149:
URL: https://github.com/apache/shardingsphere/pull/8149#issuecomment-726733591
Oh, thanks for your TWO successive PRs. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8149: Format input parameters for MySQL and Oracle visitor functions
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8149:
URL: https://github.com/apache/shardingsphere/pull/8149#issuecomment-726475605
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8149?src=pr&el=h1) Report
> Merging [#8149](https://codecov.io/gh/apache/shardingsphere/pull/8149?src=pr&el=desc) (e2e8adc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c50e3da55c676b11edbef07dbd2b81b442422df1?el=desc) (c50e3da) will **not change** coverage.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8149?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8149 +/- ##
=========================================
Coverage 73.46% 73.46%
Complexity 531 531
=========================================
Files 1445 1445
Lines 22923 22923
Branches 4117 4117
=========================================
Hits 16840 16840
+ Misses 4957 4955 -2
- Partials 1126 1128 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8149?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...itor/statement/impl/OracleStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8149/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `73.39% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...sitor/statement/impl/MySQLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8149/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `76.88% <50.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...sql/visitor/format/impl/MySQLFormatSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8149/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2Zvcm1hdC9pbXBsL015U1FMRm9ybWF0U1FMVmlzaXRvci5qYXZh) | `42.35% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...or/statement/impl/MySQLDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8149/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `42.20% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8149/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
| [...gsphere/proxy/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8149/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `50.00% <0.00%> (+2.94%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8149?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8149?src=pr&el=footer). Last update [c50e3da...e2e8adc](https://codecov.io/gh/apache/shardingsphere/pull/8149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org