You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Jeffrey Gerard (JIRA)" <ji...@apache.org> on 2011/02/10 19:00:57 UTC
[jira] Created: (HADOOP-7135) Commit 949660 broke
FileUtil.copyMerge
Commit 949660 broke FileUtil.copyMerge
--------------------------------------
Key: HADOOP-7135
URL: https://issues.apache.org/jira/browse/HADOOP-7135
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 0.21.0
Reporter: Jeffrey Gerard
Looking at http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.21/src/java/org/apache/hadoop/fs/FileUtil.java?r1=949659&r2=949660&
it seems this commit broke FileUtil.copyMerge by omitting NOT operator. copyMerge only makes sense if srcDir is a directory.
Should be
if (!srcFS.getFileStatus(srcDir).isDirectory())
return false;
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7135) Commit 949660 broke
FileUtil.copyMerge
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers resolved HADOOP-7135.
------------------------------------
Resolution: Invalid
Assignee: Jim Plush
Thanks a lot for the investigation, Jim. Closing this out.
> Commit 949660 broke FileUtil.copyMerge
> --------------------------------------
>
> Key: HADOOP-7135
> URL: https://issues.apache.org/jira/browse/HADOOP-7135
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.21.0
> Reporter: Jeffrey Gerard
> Assignee: Jim Plush
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Looking at http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.21/src/java/org/apache/hadoop/fs/FileUtil.java?r1=949659&r2=949660&
> it seems this commit broke FileUtil.copyMerge by omitting NOT operator. copyMerge only makes sense if srcDir is a directory.
> Should be
> if (!srcFS.getFileStatus(srcDir).isDirectory())
> return false;
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira