[jira] [Comment Edited] (IVY-1465) ModuleRules.getRule is O(n) leading to resolution slowness

["Shikhar Bhushan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IVY-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983159#comment-13983159 ] 

Shikhar Bhushan edited comment on IVY-1465 at 4/28/14 4:33 PM:
---------------------------------------------------------------

It's been hard to setup an isolated test for it - it always comes up in our multi-module build with inter-module dependencies, though. We also have an internal Archiva maven repository. Not sure if these factors play any part.

Anyway some good/bad news: I managed to reproduce the issue without this patch on Ivy trunk. I am going to try and bisect for the regression.


was (Author: shikhar):
It's been hard to setup an isolated test for it - it always comes up in our multi-module build with inter-module dependencies, though. We also have an internal Archiva maven repository. Not sure if these factors play any part.

Anyway some good/bad news: I managed to reproduce the issue without this patch on Ivy trunk. The 2.4-RC1 was fine. I am going to try and bisect for the regression.

> ModuleRules.getRule is O(n) leading to resolution slowness
> ----------------------------------------------------------
>
>                 Key: IVY-1465
>                 URL: https://issues.apache.org/jira/browse/IVY-1465
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.3.0
>         Environment: OpenJDK 6,7, MacOSX + Ubuntu
>            Reporter: Joshua Suereth
>            Priority: Minor
>              Labels: performance
>
> So, for the sbt project we noticed significant resolution time improvements with the following patch:
> https://github.com/sbt/ivy/pull/1
> The reasoning:
> A lot of artifacts being resolved use Maven's "dependencyManagement" conventions
> Ivy appears to turn these into "exact matcher" rules
> A ton of resolution time is spent filtering through these rules
> The existing solution is O(n) for all overrides
> What the patch does:
> Creates a key'd store for all "exact matcher" rules
> When executing rules, ensure that we only traverse what we have to (non-exact, exact specific to our key and "default").
> As I said, this represents a significant speed bump for sbt builds using Ivy.  All existing tests pass, and I think they cover this aspect of ivy pretty well, from what I could see.



--
This message was sent by Atlassian JIRA
(v6.2#6252)