Re: cvs commit: httpd-test/flood CHANGES flood_farm.c

[Aaron Bannert <aa...@clove.org>]

On Fri, Aug 24, 2001 at 05:59:58AM -0000, jerenkrantz@apache.org wrote:
> jerenkrantz    01/08/23 22:59:58
> 
>   Modified:    flood    CHANGES flood_farm.c
>   Log:
>   Okay, here's the "real" commit log for the fork()-based implementation of
>   flood.
>   
>   - Remove FLOOD_USE_THREADS as we have no way of determining if we have
>     threads other than APR.  (We'd say that threads were always enabled.)
>     I feel comfortable using APR's thread detection rather than mucking
>     with parameters ourselves.
>   - Add strtoq conversion for FreeBSD that #defines it to strtoll.  This
>     is a tad cheesy.  Thoughts?  I don't want to have #ifdef HAVE_STRTOLL
>     and #ifdef HAVE_STRTOQ all over the place.  Smells like an APR function.

does linux have strtoll? IIRC, we're just reading it into an 'int' anyway,
so why the long long?

>   - Remove forking stuff in flood.c as it doesn't make sense to fork() here
>     anyway as this is only bootstrap code.
>   - Make reports output either the current thread id or the pid

I assume this is only temporary until we have a better GUID? We really
shouldn't be calling apr_os_thread_id() and then trying to print it as
an int. How about just a counter for each new thread/process?

>   - Don't do OpenSSL locking when we aren't threaded

cool.

>   - Not all OpenSSL versions (FreeBSD 4.2 has 0.9.5a) has AUTO_RETRY.  So,
>     only set that option if we have that symbol.
>   
>   So, we now support FreeBSD.  Go forth.

very cool.

-aaron

Re: cvs commit: httpd-test/flood CHANGES flood_farm.c

[Aaron Bannert <aa...@clove.org>]

On Thu, Aug 23, 2001 at 11:28:55PM -0700, Justin Erenkrantz wrote:
> On Thu, Aug 23, 2001 at 11:18:11PM -0700, Aaron Bannert wrote:
> > does linux have strtoll? IIRC, we're just reading it into an 'int' anyway,
> > so why the long long?
> 
> You wrote that code.  =)  I didn't even know strtoll existed.  I use
> strtol.

Wow that was a weird typo then. A typo that works? ;)
Looks like I did, but we have strtol() in some places and strtoll()
in others. I don't think it really matters, since strtol() on linux
is a long int anyway (which I have no idea how many words that is). If
anything, maybe we should make them all strtol().

> > >   - Remove forking stuff in flood.c as it doesn't make sense to fork() here
> > >     anyway as this is only bootstrap code.
> > >   - Make reports output either the current thread id or the pid
> > 
> > I assume this is only temporary until we have a better GUID? We really
> > shouldn't be calling apr_os_thread_id() and then trying to print it as
> > an int. How about just a counter for each new thread/process?
> 
> Maybe.  Commit it.  I don't care.  I do like the fact that when
> debugging I can correlate that to the thread/process id.  That's a
> bonus.  -- justin

I'll put it in the STATUS file for now, I'm tired ;)

-a

Re: cvs commit: httpd-test/flood CHANGES flood_farm.c

[Justin Erenkrantz <je...@ebuilt.com>]

On Thu, Aug 23, 2001 at 11:18:11PM -0700, Aaron Bannert wrote:
> does linux have strtoll? IIRC, we're just reading it into an 'int' anyway,
> so why the long long?

You wrote that code.  =)  I didn't even know strtoll existed.  I use
strtol.

> >   - Remove forking stuff in flood.c as it doesn't make sense to fork() here
> >     anyway as this is only bootstrap code.
> >   - Make reports output either the current thread id or the pid
> 
> I assume this is only temporary until we have a better GUID? We really
> shouldn't be calling apr_os_thread_id() and then trying to print it as
> an int. How about just a counter for each new thread/process?

Maybe.  Commit it.  I don't care.  I do like the fact that when
debugging I can correlate that to the thread/process id.  That's a
bonus.  -- justin