You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/10 02:39:00 UTC
[GitHub] [cordova-android] brodybits opened a new pull request #999: cleanup: remove trailing spaces from Java sources
brodybits opened a new pull request #999:
URL: https://github.com/apache/cordova-android/pull/999
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
see title
### Description
<!-- Describe your changes in detail -->
see title
### Testing
<!-- Please describe in detail how you tested your changes. -->
✅ `npm test` in my work area - OK
✅ tried using in `cordova-sqlite-storage` test app - OK
### Checklist
- [ ] I've run the tests to see all new and existing tests pass - both in work area and in GitHub CI
- ~~I added automated test coverage as appropriate for this change~~
- ~~Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)~~
- ~~If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))~~
- ~~I've updated the documentation if necessary~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] brodybits commented on pull request #999: cleanup: remove trailing spaces from Java sources
Posted by GitBox <gi...@apache.org>.
brodybits commented on pull request #999:
URL: https://github.com/apache/cordova-android/pull/999#issuecomment-641691636
In general, I think we should do this cleanup through all of our repositories and look for a way to avoid trailing whitespaces in the future. I learned about `git grep` pretty recently, looks like a good friend, and discovered this for finding tabs: https://stackoverflow.com/questions/4262150/is-it-possible-to-git-grep-for-tabs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #999: cleanup: remove trailing spaces from Java sources
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #999:
URL: https://github.com/apache/cordova-android/pull/999#issuecomment-641685422
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=h1) Report
> Merging [#999](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/dead4b4ab6f0aea37bed5cdb0b9a3b3dcd94698d&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #999 +/- ##
==========================================
- Coverage 68.11% 68.06% -0.06%
==========================================
Files 21 21
Lines 1866 1866
==========================================
- Hits 1271 1270 -1
- Misses 595 596 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/999/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.06% <0.00%> (-0.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=footer). Last update [dead4b4...b121a10](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #999: cleanup: remove trailing spaces from Java sources
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #999:
URL: https://github.com/apache/cordova-android/pull/999#issuecomment-641685422
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=h1) Report
> Merging [#999](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/dead4b4ab6f0aea37bed5cdb0b9a3b3dcd94698d&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 68.11% 68.11%
=======================================
Files 21 21
Lines 1866 1866
=======================================
Hits 1271 1271
Misses 595 595
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=footer). Last update [dead4b4...b121a10](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #999: cleanup: remove trailing spaces from Java sources
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #999:
URL: https://github.com/apache/cordova-android/pull/999#issuecomment-641685422
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=h1) Report
> Merging [#999](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/dead4b4ab6f0aea37bed5cdb0b9a3b3dcd94698d&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #999 +/- ##
==========================================
- Coverage 68.11% 68.06% -0.06%
==========================================
Files 21 21
Lines 1866 1866
==========================================
- Hits 1271 1270 -1
- Misses 595 596 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/999/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.06% <0.00%> (-0.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=footer). Last update [dead4b4...b121a10](https://codecov.io/gh/apache/cordova-android/pull/999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #999: cleanup: remove trailing spaces from Java sources
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #999:
URL: https://github.com/apache/cordova-android/pull/999#issuecomment-641692239
Could even look at implementing java/android lint
https://developer.android.com/studio/write/lint
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] brodybits merged pull request #999: cleanup: remove trailing spaces from Java sources
Posted by GitBox <gi...@apache.org>.
brodybits merged pull request #999:
URL: https://github.com/apache/cordova-android/pull/999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org