You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/05/22 22:43:18 UTC

Review Request: integration test for advanced zone with security groups

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11332/
-----------------------------------------------------------

Review request for cloudstack and anthony xu.


Description
-------

This patch includes three parts for advancedsg:
(1) Marvin support.
(2) devcloud support.
(3) integration test scripts.


Diffs
-----

  setup/dev/advancedsg.cfg PRE-CREATION 
  test/integration/component/test_advancedsg_networks.py PRE-CREATION 
  test/integration/component/test_egress_rules.py 872ca2c 
  test/integration/component/test_security_groups.py 2ed27fe 
  tools/devcloud/devcloud-advancedsg.cfg PRE-CREATION 
  tools/marvin/marvin/configGenerator.py 4e82bbe 
  tools/marvin/marvin/deployDataCenter.py 7059059 
  tools/marvin/marvin/sandbox/advancedsg/__init__.py PRE-CREATION 
  tools/marvin/marvin/sandbox/advancedsg/advancedsg_env.py PRE-CREATION 
  tools/marvin/marvin/sandbox/advancedsg/setup.properties PRE-CREATION 
  tools/marvin/setup.py 8dfd1b8 

Diff: https://reviews.apache.org/r/11332/diff/


Testing
-------

devcloud testing ok.
integration test need to be verified.


Thanks,

Wei Zhou


Re: Review Request: integration test for advanced zone with security groups

Posted by Prasanna Santhanam <ts...@apache.org>.

> On May 23, 2013, 5:16 a.m., Prasanna Santhanam wrote:
> > +1
> > 
> > This looks super complete! Thanks for changing everything necessary!
> > 
> > Since you are already a committer, would you like to commit this yourself?

I'll setup the advanced security group zone across KVM on jenkins.buildacloud.org and verify your tests. Will publish the run reports


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11332/#review20926
-----------------------------------------------------------


On May 22, 2013, 8:43 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11332/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 8:43 p.m.)
> 
> 
> Review request for cloudstack and anthony xu.
> 
> 
> Description
> -------
> 
> This patch includes three parts for advancedsg:
> (1) Marvin support.
> (2) devcloud support.
> (3) integration test scripts.
> 
> 
> Diffs
> -----
> 
>   setup/dev/advancedsg.cfg PRE-CREATION 
>   test/integration/component/test_advancedsg_networks.py PRE-CREATION 
>   test/integration/component/test_egress_rules.py 872ca2c 
>   test/integration/component/test_security_groups.py 2ed27fe 
>   tools/devcloud/devcloud-advancedsg.cfg PRE-CREATION 
>   tools/marvin/marvin/configGenerator.py 4e82bbe 
>   tools/marvin/marvin/deployDataCenter.py 7059059 
>   tools/marvin/marvin/sandbox/advancedsg/__init__.py PRE-CREATION 
>   tools/marvin/marvin/sandbox/advancedsg/advancedsg_env.py PRE-CREATION 
>   tools/marvin/marvin/sandbox/advancedsg/setup.properties PRE-CREATION 
>   tools/marvin/setup.py 8dfd1b8 
> 
> Diff: https://reviews.apache.org/r/11332/diff/
> 
> 
> Testing
> -------
> 
> devcloud testing ok.
> integration test need to be verified.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Re: Review Request: integration test for advanced zone with security groups

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11332/#review20926
-----------------------------------------------------------

Ship it!


+1

This looks super complete! Thanks for changing everything necessary!

Since you are already a committer, would you like to commit this yourself?

- Prasanna Santhanam


On May 22, 2013, 8:43 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11332/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 8:43 p.m.)
> 
> 
> Review request for cloudstack and anthony xu.
> 
> 
> Description
> -------
> 
> This patch includes three parts for advancedsg:
> (1) Marvin support.
> (2) devcloud support.
> (3) integration test scripts.
> 
> 
> Diffs
> -----
> 
>   setup/dev/advancedsg.cfg PRE-CREATION 
>   test/integration/component/test_advancedsg_networks.py PRE-CREATION 
>   test/integration/component/test_egress_rules.py 872ca2c 
>   test/integration/component/test_security_groups.py 2ed27fe 
>   tools/devcloud/devcloud-advancedsg.cfg PRE-CREATION 
>   tools/marvin/marvin/configGenerator.py 4e82bbe 
>   tools/marvin/marvin/deployDataCenter.py 7059059 
>   tools/marvin/marvin/sandbox/advancedsg/__init__.py PRE-CREATION 
>   tools/marvin/marvin/sandbox/advancedsg/advancedsg_env.py PRE-CREATION 
>   tools/marvin/marvin/sandbox/advancedsg/setup.properties PRE-CREATION 
>   tools/marvin/setup.py 8dfd1b8 
> 
> Diff: https://reviews.apache.org/r/11332/diff/
> 
> 
> Testing
> -------
> 
> devcloud testing ok.
> integration test need to be verified.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>