You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/03/17 13:54:09 UTC

[Bug 54712] New: Prefer Locale.ENGLISH over Locale.US for case conversion

https://issues.apache.org/bugzilla/show_bug.cgi?id=54712

            Bug ID: 54712
           Summary: Prefer Locale.ENGLISH over Locale.US for case
                    conversion
           Product: Tomcat 7
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: sebb@apache.org
    Classification: Unclassified

Created attachment 30060
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30060&action=edit
Convert Locale.US to Locale.ENGLISH in case conversion methods

Case-conversion using toLowerCase or toUpperCase needs a Locale parameter to
avoid using the default (with possibly unexpected results in some Locales).

The code currently uses Locale.US in several places.
However most of the code uses Locale.ENGLISH.
The code should standardise on ENGLISH.

Or perhaps consider using Locale.ROOT (@since 1.6)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 54712] Prefer Locale.ENGLISH over Locale.US for case conversion

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54712

--- Comment #2 from Sebb <se...@apache.org> ---
(In reply to comment #1)
> Note: The provided patch is against trunk rather than 7.0.x/trunk.

Oops! Sorry, my IDE project was named when trunk was 7.0.x and I forgot to
update it.

> This change has been made to trunk and 7.0.x and will be included in 7.0.39
> onwards.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 54712] Prefer Locale.ENGLISH over Locale.US for case conversion

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54712

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Severity|trivial                     |enhancement

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
There is no bug here. s/US/ENGLISH/ has no functional difference. This is an
enhancement.

Note: The provided patch is against trunk rather than 7.0.x/trunk.

This change has been made to trunk and 7.0.x and will be included in 7.0.39
onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org