You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/10/07 09:14:06 UTC
[GitHub] [thrift] Jimexist opened a new pull request, #2690: THRIFT-5633: move xenial to old, deprecate xenial in travis build
Jimexist opened a new pull request, #2690:
URL: https://github.com/apache/thrift/pull/2690
<!-- Explain the changes in the pull request below: -->
- move xenial to old
- deprecate xenial in travis build
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2690: THRIFT-5633: move xenial to old, deprecate xenial in travis build
Posted by GitBox <gi...@apache.org>.
fishy commented on PR #2690:
URL: https://github.com/apache/thrift/pull/2690#issuecomment-1272558422
sure as I said that can totally be done in a follow up pr instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist merged pull request #2690: THRIFT-5633: move xenial to old, deprecate xenial in travis build
Posted by GitBox <gi...@apache.org>.
Jimexist merged PR #2690:
URL: https://github.com/apache/thrift/pull/2690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2690: THRIFT-5633: move xenial to old, deprecate xenial in travis build
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2690:
URL: https://github.com/apache/thrift/pull/2690#issuecomment-1272269953
to add jammy see #2684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on a diff in pull request #2690: THRIFT-5633: move xenial to old, deprecate xenial in travis build
Posted by GitBox <gi...@apache.org>.
fishy commented on code in PR #2690:
URL: https://github.com/apache/thrift/pull/2690#discussion_r990237727
##########
.travis.yml:
##########
@@ -58,12 +58,6 @@ env:
jobs:
include:
# ========================= stage: docker =========================
- - stage: docker
Review Comment:
it looks like we would still want to keep this line (but remove `script` and `env` lines below)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on a diff in pull request #2690: THRIFT-5633: move xenial to old, deprecate xenial in travis build
Posted by GitBox <gi...@apache.org>.
Jimexist commented on code in PR #2690:
URL: https://github.com/apache/thrift/pull/2690#discussion_r990584825
##########
.travis.yml:
##########
@@ -58,12 +58,6 @@ env:
jobs:
include:
# ========================= stage: docker =========================
- - stage: docker
Review Comment:
yes i now kept the stage line; the env and script were mismatched due to git diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2690: THRIFT-5633: move xenial to old, deprecate xenial in travis build
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2690:
URL: https://github.com/apache/thrift/pull/2690#issuecomment-1272551188
> It doesn't seem the travis issues are caused by this change (but I don't remember seeing the c++ and python test failures before 🤔)
>
> also a minor thing that can totally be done in another PR after this: currently since we support 2 go versions, we use xenial for the older version and bionic+focal for the newer version:
>
> * https://github.com/apache/thrift/blob/4f72788418d8ee331d8841310a4066fd0ba2e510/build/docker/ubuntu-xenial/Dockerfile#L139
> * https://github.com/apache/thrift/blob/4f72788418d8ee331d8841310a4066fd0ba2e510/build/docker/ubuntu-bionic/Dockerfile#L147
> * https://github.com/apache/thrift/blob/4f72788418d8ee331d8841310a4066fd0ba2e510/build/docker/ubuntu-focal/Dockerfile#L148
>
> now with xenial going away, we would need to shift bionic (which would be the new oldest version we run on travis) to the older go version in order to still test both.
hi @fishy how do you feel is that testing 1.18 is done in #2697 (as a follow up), then we don't need to update in here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org