You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/09/07 13:52:06 UTC

[lucene-solr] branch reference_impl_dev updated: @776 Harden for this delete test - really delete should be empty json.

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl_dev by this push:
     new f9db302  @776 Harden for this delete test - really delete should be empty json.
f9db302 is described below

commit f9db302677e7013d04c0d9624f573ad7d24a1aaf
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Mon Sep 7 08:51:47 2020 -0500

    @776 Harden for this delete test - really delete should be empty json.
---
 solr/core/src/test/org/apache/solr/cloud/CollectionPropsTest.java | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/solr/core/src/test/org/apache/solr/cloud/CollectionPropsTest.java b/solr/core/src/test/org/apache/solr/cloud/CollectionPropsTest.java
index a8441f7..a73cd35 100644
--- a/solr/core/src/test/org/apache/solr/cloud/CollectionPropsTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/CollectionPropsTest.java
@@ -193,7 +193,13 @@ public class CollectionPropsTest extends SolrCloudTestCase {
     log.info("deleting props");
     zkStateReader.getZkClient().delete("/collections/" + collectionName + "/collectionprops.json", -1);
     watcher.waitForTrigger();
-    final Map<String, String> props = watcher.getProps();
+    Map<String, String> props = watcher.getProps();
+
+    // TODO: delete is not a normal, good op here (should clear the file) and it may take a moment to arrive
+    if (!props.isEmpty()) {
+      Thread.sleep(100);
+    }
+    props = watcher.getProps();
     assertTrue(props.toString(), props.isEmpty());
   }