You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/11/26 01:17:39 UTC
Review Request 28457: user and group properties should be created
dynamically
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28457/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-8451
https://issues.apache.org/jira/browse/AMBARI-8451
Repository: ambari
Description
-------
For making a user or group properties appear in MISC tab with a user friendly name, it is required to have definition of such properties in ambari-web configuration metadata i.e. in site_properties.js file.
>From 1.7.0 release such user/group properties are tagged with an attribute property_type as USER or GROUP by the API and so the definition of these properties can be prepared in the code dynamically by looking for such property_types. This will eliminate the need of adding a user or group definition every time a new service is introduced in a stack.
Diffs
-----
ambari-web/app/controllers/main/admin/serviceAccounts_controller.js 94221aa
ambari-web/app/controllers/main/service/info/configs.js 31ea2ec
ambari-web/app/data/HDP2/site_properties.js 0f68c61
ambari-web/app/data/site_properties.js 5fc2d6e
ambari-web/app/utils/ajax/ajax.js 4c3d74d
ambari-web/app/utils/config.js 5b15dc1
ambari-web/app/views/common/configs/services_config.js 586182c
ambari-web/test/mock_data_setup/configs_mock_data.js 45a0926
ambari-web/test/utils/config_test.js 4cefc7d
Diff: https://reviews.apache.org/r/28457/diff/
Testing
-------
tested e2e.
Thanks,
Jaimin Jetly
Re: Review Request 28457: user and group properties should be created
dynamically
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28457/#review63091
-----------------------------------------------------------
Ship it!
Ship It!
- Xi Wang
On Nov. 25, 2014, 4:59 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28457/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 4:59 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-8451
> https://issues.apache.org/jira/browse/AMBARI-8451
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For making a user or group properties appear in MISC tab with a user friendly name, it is required to have definition of such properties in ambari-web configuration metadata i.e. in site_properties.js file.
> From 1.7.0 release such user/group properties are tagged with an attribute property_type as USER or GROUP by the API and so the definition of these properties can be prepared in the code dynamically by looking for such property_types. This will eliminate the need of adding a user or group definition every time a new service is introduced in a stack.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/serviceAccounts_controller.js 94221aa
> ambari-web/app/controllers/main/service/info/configs.js 31ea2ec
> ambari-web/app/data/HDP2/site_properties.js 0f68c61
> ambari-web/app/data/site_properties.js 5fc2d6e
> ambari-web/app/utils/ajax/ajax.js 4c3d74d
> ambari-web/app/utils/config.js 5b15dc1
> ambari-web/app/views/common/configs/services_config.js 586182c
> ambari-web/test/mock_data_setup/configs_mock_data.js 45a0926
> ambari-web/test/utils/config_test.js 4cefc7d
>
> Diff: https://reviews.apache.org/r/28457/diff/
>
>
> Testing
> -------
>
> tested e2e.
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 28457: user and group properties should be created
dynamically
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28457/
-----------------------------------------------------------
(Updated Nov. 26, 2014, 12:59 a.m.)
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-8451
https://issues.apache.org/jira/browse/AMBARI-8451
Repository: ambari
Description
-------
For making a user or group properties appear in MISC tab with a user friendly name, it is required to have definition of such properties in ambari-web configuration metadata i.e. in site_properties.js file.
>From 1.7.0 release such user/group properties are tagged with an attribute property_type as USER or GROUP by the API and so the definition of these properties can be prepared in the code dynamically by looking for such property_types. This will eliminate the need of adding a user or group definition every time a new service is introduced in a stack.
Diffs
-----
ambari-web/app/controllers/main/admin/serviceAccounts_controller.js 94221aa
ambari-web/app/controllers/main/service/info/configs.js 31ea2ec
ambari-web/app/data/HDP2/site_properties.js 0f68c61
ambari-web/app/data/site_properties.js 5fc2d6e
ambari-web/app/utils/ajax/ajax.js 4c3d74d
ambari-web/app/utils/config.js 5b15dc1
ambari-web/app/views/common/configs/services_config.js 586182c
ambari-web/test/mock_data_setup/configs_mock_data.js 45a0926
ambari-web/test/utils/config_test.js 4cefc7d
Diff: https://reviews.apache.org/r/28457/diff/
Testing
-------
tested e2e.
Thanks,
Jaimin Jetly
Re: Review Request 28457: user and group properties should be created
dynamically
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28457/
-----------------------------------------------------------
(Updated Nov. 26, 2014, 12:28 a.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-8451
https://issues.apache.org/jira/browse/AMBARI-8451
Repository: ambari
Description
-------
For making a user or group properties appear in MISC tab with a user friendly name, it is required to have definition of such properties in ambari-web configuration metadata i.e. in site_properties.js file.
>From 1.7.0 release such user/group properties are tagged with an attribute property_type as USER or GROUP by the API and so the definition of these properties can be prepared in the code dynamically by looking for such property_types. This will eliminate the need of adding a user or group definition every time a new service is introduced in a stack.
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/serviceAccounts_controller.js 94221aa
ambari-web/app/controllers/main/service/info/configs.js 31ea2ec
ambari-web/app/data/HDP2/site_properties.js 0f68c61
ambari-web/app/data/site_properties.js 5fc2d6e
ambari-web/app/utils/ajax/ajax.js 4c3d74d
ambari-web/app/utils/config.js 5b15dc1
ambari-web/app/views/common/configs/services_config.js 586182c
ambari-web/test/mock_data_setup/configs_mock_data.js 45a0926
ambari-web/test/utils/config_test.js 4cefc7d
Diff: https://reviews.apache.org/r/28457/diff/
Testing
-------
tested e2e.
Thanks,
Jaimin Jetly