You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/07/20 15:46:34 UTC
[GitHub] [hive] kuczoram opened a new pull request #2502: HIVE-25357: Fix the checkstyle issue in HiveIcebergMetaHook which bre…
kuczoram opened a new pull request #2502:
URL: https://github.com/apache/hive/pull/2502
…aks the build
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kuczoram closed pull request #2502: HIVE-25357: Fix the checkstyle issue in HiveIcebergMetaHook and the iceberg test issues to unblock the pre-commit tests
Posted by GitBox <gi...@apache.org>.
kuczoram closed pull request #2502:
URL: https://github.com/apache/hive/pull/2502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] marton-bod commented on pull request #2502: HIVE-25357: Fix the checkstyle issue in HiveIcebergMetaHook and the iceberg test issues to unblock the pre-commit tests
Posted by GitBox <gi...@apache.org>.
marton-bod commented on pull request #2502:
URL: https://github.com/apache/hive/pull/2502#issuecomment-883664839
Looking at the history of HiveIcebergMetaHook changes: https://github.com/apache/hive/commits/master/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
It's almost certainly a conflict with this: https://issues.apache.org/jira/browse/HIVE-25256
My patch got merged yesterday (changing the metahook), the stats generation changed the metahook too but its green run was 5 days old, then it was merged too -> BOOM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kuczoram commented on pull request #2502: HIVE-25357: Fix the checkstyle issue in HiveIcebergMetaHook and the iceberg test issues to unblock the pre-commit tests
Posted by GitBox <gi...@apache.org>.
kuczoram commented on pull request #2502:
URL: https://github.com/apache/hive/pull/2502#issuecomment-883661890
> > Are you ok to revert it?
>
> Sure. Revert it, and later we will try to find out what caused the conflict. The change had a green run before the merge, so there should be some other conflicting change, and the 2 of them are causing the issues together.
>
> But if we know the last one we definitely want to revert it
Ok, created a PR for the revert:
https://github.com/apache/hive/pull/2505
Yes, most probably there is some interference with a previous PR. We can find out which one and can fix it later then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kuczoram commented on pull request #2502: HIVE-25357: Fix the checkstyle issue in HiveIcebergMetaHook and the iceberg test issues to unblock the pre-commit tests
Posted by GitBox <gi...@apache.org>.
kuczoram commented on pull request #2502:
URL: https://github.com/apache/hive/pull/2502#issuecomment-883654124
> Do we know what caused the issue? Can we just revert the change?
Most probably this one: https://issues.apache.org/jira/browse/HIVE-25276
The build failure is definitely because of this patch, as the build failed on that commit. The tests are also very probably.
Are you ok to revert it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #2502: HIVE-25357: Fix the checkstyle issue in HiveIcebergMetaHook and the iceberg test issues to unblock the pre-commit tests
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #2502:
URL: https://github.com/apache/hive/pull/2502#issuecomment-883657350
> Are you ok to revert it?
Sure. Revert it, and later we will try to find out what caused the conflict. The change had a green run before the merge, so there should be some other conflicting change, and the 2 of them are causing the issues together.
But if we know the last one we definitely want to revert it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #2502: HIVE-25357: Fix the checkstyle issue in HiveIcebergMetaHook and the iceberg test issues to unblock the pre-commit tests
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #2502:
URL: https://github.com/apache/hive/pull/2502#issuecomment-883651739
Do we know what caused the issue? Can we just revert the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kuczoram commented on pull request #2502: HIVE-25357: Fix the checkstyle issue in HiveIcebergMetaHook and the iceberg test issues to unblock the pre-commit tests
Posted by GitBox <gi...@apache.org>.
kuczoram commented on pull request #2502:
URL: https://github.com/apache/hive/pull/2502#issuecomment-883664458
Close this PR, as the problematic commit got reverted, so we will have time to fix the tests properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kuczoram edited a comment on pull request #2502: HIVE-25357: Fix the checkstyle issue in HiveIcebergMetaHook and the iceberg test issues to unblock the pre-commit tests
Posted by GitBox <gi...@apache.org>.
kuczoram edited a comment on pull request #2502:
URL: https://github.com/apache/hive/pull/2502#issuecomment-883654124
> Do we know what caused the issue? Can we just revert the change?
Most probably this one: https://issues.apache.org/jira/browse/HIVE-25276
The build failure is definitely because of this patch, as the build failed on that commit:
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/master/771/pipeline/
Are you ok to revert it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org