You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2009/07/21 11:23:56 UTC

svn commit: r796209 - /qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/RefreshIntervalComboPanel.java

Author: robbie
Date: Tue Jul 21 09:23:55 2009
New Revision: 796209

URL: http://svn.apache.org/viewvc?rev=796209&view=rev
Log:
QPID-1994: prevent NPE caused by refreshing whilst app is closing down

Modified:
    qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/RefreshIntervalComboPanel.java

Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/RefreshIntervalComboPanel.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/RefreshIntervalComboPanel.java?rev=796209&r1=796208&r2=796209&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/RefreshIntervalComboPanel.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/RefreshIntervalComboPanel.java Tue Jul 21 09:23:55 2009
@@ -106,21 +106,24 @@
         @Override
         public void run()
         {
-            IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow(); 
-            final MBeanView mbView = (MBeanView)window.getActivePage().findView(MBeanView.ID);
-
-            final NavigationView navView = (NavigationView)window.getActivePage().findView(NavigationView.ID);
-            try
-            {
-                mbView.refresh();
-                navView.refresh();
-            }
-            catch (Exception ex)
+            IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
+            if(window != null)
             {
-                MBeanUtility.handleException(ex);
-            }
+                final MBeanView mbView = (MBeanView)window.getActivePage().findView(MBeanView.ID);
+
+                final NavigationView navView = (NavigationView)window.getActivePage().findView(NavigationView.ID);
+                try
+                {
+                    mbView.refresh();
+                    navView.refresh();
+                }
+                catch (Exception ex)
+                {
+                    MBeanUtility.handleException(ex);
+                }
 
-            _display.timerExec(1000 * seconds, this);
+                _display.timerExec(1000 * seconds, this);
+            }
         }
         
     }



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org