You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2010/02/02 18:10:11 UTC
svn commit: r905710 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: markt
Date: Tue Feb 2 17:10:05 2010
New Revision: 905710
URL: http://svn.apache.org/viewvc?rev=905710&view=rev
Log:
Proposal
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=905710&r1=905709&r2=905710&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Feb 2 17:10:05 2010
@@ -168,4 +168,8 @@
kkolinko: LinkedHashMap is present in JDK 1.4 (At first I thought it was
added in 1.5 only, but I was wrong).
-
\ No newline at end of file
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48581
+ Avoid security exception on first access
+ http://people.apache.org/~markt/patches/2010-02-02-bug48581.patch
+ +1: markt
+ -1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r905710 - /tomcat/tc5.5.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/2/2 Konstantin Kolinko <kn...@gmail.com>:
> 2010/2/2 Mark Thomas <ma...@apache.org>:
>> On 02/02/2010 17:31, Konstantin Kolinko wrote:
>>> 2010/2/2 <ma...@apache.org>:
>>>> Author: markt
>>>> Date: Tue Feb 2 17:10:05 2010
>>>> New Revision: 905710
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=905710&view=rev
>>>> Log:
>>>> Proposal
>>>>
>>>> Modified:
>>>> tomcat/tc5.5.x/trunk/STATUS.txt
>>>>
>>>
>>>> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48581
>>>> + Avoid security exception on first access
>>>> + http://people.apache.org/~markt/patches/2010-02-02-bug48581.patch
>>>> + +1: markt
>>>> + -1:
>>>
>>> A very elaborate patch. So, it was "org.apache.coyote.Constants".
>>> I thought that we would just preload the class.
>>
>> Yeah, it did get a bit out of hand. Pre-loading should work too.
>>
I tried to preload "org.apache.coyote.Constants", and it doesn't fix the issue.
While class is preloaded, its class initialization (<clinit> call)
still occurs during InternalOutputBuffer.sendStatus(), thus I am
getting
java.security.AccessControlException: access denied
(java.util.PropertyPermission
org.apache.coyote.USE_CUSTOM_STATUS_MSG_IN_HEADER read)
in localhost.2010-02-03.log, followed by
java.lang.NoClassDefFoundError: Could not initialize class
org.apache.coyote.Constants
in catalina.2010-02-03.log
Your patch works. Let's go with it.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r905710 - /tomcat/tc5.5.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/2/2 Mark Thomas <ma...@apache.org>:
> On 02/02/2010 17:31, Konstantin Kolinko wrote:
>> 2010/2/2 <ma...@apache.org>:
>>> Author: markt
>>> Date: Tue Feb 2 17:10:05 2010
>>> New Revision: 905710
>>>
>>> URL: http://svn.apache.org/viewvc?rev=905710&view=rev
>>> Log:
>>> Proposal
>>>
>>> Modified:
>>> tomcat/tc5.5.x/trunk/STATUS.txt
>>>
>>
>>> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48581
>>> + Avoid security exception on first access
>>> + http://people.apache.org/~markt/patches/2010-02-02-bug48581.patch
>>> + +1: markt
>>> + -1:
>>
>> A very elaborate patch. So, it was "org.apache.coyote.Constants".
>> I thought that we would just preload the class.
>
> Yeah, it did get a bit out of hand. Pre-loading should work too.
>>
>> Also, it would be better to do the same for trunk and 6.0 as well.
>
> Is the error reproducible on those versions?
>
Fair question. It is not needed there.
In 6.0 and trunk there are a lot of classes (such as Http11Processor)
that reference o.a.coyote.Constants. Because of that it will be
loaded when connectors are instantiated.
There are far less references to it in TC5.5.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r905710 - /tomcat/tc5.5.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
On 02/02/2010 17:31, Konstantin Kolinko wrote:
> 2010/2/2 <ma...@apache.org>:
>> Author: markt
>> Date: Tue Feb 2 17:10:05 2010
>> New Revision: 905710
>>
>> URL: http://svn.apache.org/viewvc?rev=905710&view=rev
>> Log:
>> Proposal
>>
>> Modified:
>> tomcat/tc5.5.x/trunk/STATUS.txt
>>
>
>> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48581
>> + Avoid security exception on first access
>> + http://people.apache.org/~markt/patches/2010-02-02-bug48581.patch
>> + +1: markt
>> + -1:
>
> A very elaborate patch. So, it was "org.apache.coyote.Constants".
> I thought that we would just preload the class.
Yeah, it did get a bit out of hand. Pre-loading should work too.
>
> Also, it would be better to do the same for trunk and 6.0 as well.
Is the error reproducible on those versions?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r905710 - /tomcat/tc5.5.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/2/2 <ma...@apache.org>:
> Author: markt
> Date: Tue Feb 2 17:10:05 2010
> New Revision: 905710
>
> URL: http://svn.apache.org/viewvc?rev=905710&view=rev
> Log:
> Proposal
>
> Modified:
> tomcat/tc5.5.x/trunk/STATUS.txt
>
> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48581
> + Avoid security exception on first access
> + http://people.apache.org/~markt/patches/2010-02-02-bug48581.patch
> + +1: markt
> + -1:
A very elaborate patch. So, it was "org.apache.coyote.Constants".
I thought that we would just preload the class.
Also, it would be better to do the same for trunk and 6.0 as well.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org