You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Aaron Hillegass (JIRA)" <qp...@incubator.apache.org> on 2009/11/17 03:01:39 UTC
[jira] Created: (QPID-2206) thread-local storage prevents build on
Mac
thread-local storage prevents build on Mac
------------------------------------------
Key: QPID-2206
URL: https://issues.apache.org/jira/browse/QPID-2206
Project: Qpid
Issue Type: Bug
Components: Build Tools
Affects Versions: 0.5
Environment: Mac OS X 10.5, Xcode 3.2.1
Reporter: Aaron Hillegass
A lack of thread-local storage prevents a build on the Mac:
g++ -DHAVE_CONFIG_H -I. -Igen -I./gen -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -g -O2 -MT qpid/sys/posix/AsynchIO.lo -MD -MP -MF qpid/sys/posix/.deps/AsynchIO.Tpo -c qpid/sys/posix/AsynchIO.cpp -fno-common -DPIC -o qpid/sys/posix/.libs/AsynchIO.o
qpid/sys/posix/AsynchIO.cpp:61: error: thread-local storage not supported for this target
qpid/sys/posix/AsynchIO.cpp:62: error: thread-local storage not supported for this target
qpid/sys/posix/AsynchIO.cpp:63: error: thread-local storage not supported for this target
qpid/sys/posix/AsynchIO.cpp:64: error: thread-local storage not supported for this target
qpid/sys/posix/AsynchIO.cpp:65: error: thread-local storage not supported for this target
qpid/sys/posix/AsynchIO.cpp:66: error: thread-local storage not supported for this target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2206) thread-local storage prevents build
on Mac
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854309#action_12854309 ]
Andrew Stitcher commented on QPID-2206:
---------------------------------------
I think there are a number of issues with the TSS part of this patch:
1. Using a new pthread_key_create() for each and every TSS variable is a very bad idea IMO. There is a limit to the number of keys that can be allocated. 128 is a typical value and there is no way to ensure the number of uses in our code. Of course we also use external libraries which may themselves use an unknown number of keys. We are also (in the client case) a library in someone else's executable it would be unfriendly to use large numbers of keys. The recommended thing to do is to use a single key per program or library.
2. I think putting all the code in a header file is a bad and unnecessary idea. Particularly there is a non-inline function defined there which would be in the object files multiple times, and will require the linker to figure out that it's duplicated.
3. It looks to me that the code has no way to eliminate simultaneous construction of the same ThreadSpec in multiple threads concurrently, this can happen if you use a function static __thread which is certainly allowed by the extension and is a useful thing to do (I'm not sure if our code does this, but it could).
4. I'm not clear that the equivalent to the construction " __thread int a(456)" would be dealt with correctly.
5. I think the most viable solution to this problem involves modifying the qpid::sys::Thread class so that it allocates a single key and then deals with allocating space in memory refered to by this key when necessary. Unfortunately I suspect this is considerably more work than this approach, and probably involves some C++ nasties like in place construction and destruction.
> thread-local storage prevents build on Mac
> ------------------------------------------
>
> Key: QPID-2206
> URL: https://issues.apache.org/jira/browse/QPID-2206
> Project: Qpid
> Issue Type: Bug
> Components: Build Tools
> Affects Versions: 0.5
> Environment: Mac OS X 10.5, Xcode 3.2.1
> Reporter: Aaron Hillegass
> Attachments: qpidc-0.6-no-tss.patch.bz2
>
>
> A lack of thread-local storage prevents a build on the Mac:
> g++ -DHAVE_CONFIG_H -I. -Igen -I./gen -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -g -O2 -MT qpid/sys/posix/AsynchIO.lo -MD -MP -MF qpid/sys/posix/.deps/AsynchIO.Tpo -c qpid/sys/posix/AsynchIO.cpp -fno-common -DPIC -o qpid/sys/posix/.libs/AsynchIO.o
> qpid/sys/posix/AsynchIO.cpp:61: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:62: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:63: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:64: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:65: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:66: error: thread-local storage not supported for this target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2206) thread-local storage prevents build
on Mac
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853990#action_12853990 ]
Alan Conway commented on QPID-2206:
-----------------------------------
I think that this line
# define QPID_TSS __thread
Has to be changed to
# define QPID_TSS(TYPE) __thread TYPE
So the macro is compatible in both cases. Otherwise I think it looks OK.
> thread-local storage prevents build on Mac
> ------------------------------------------
>
> Key: QPID-2206
> URL: https://issues.apache.org/jira/browse/QPID-2206
> Project: Qpid
> Issue Type: Bug
> Components: Build Tools
> Affects Versions: 0.5
> Environment: Mac OS X 10.5, Xcode 3.2.1
> Reporter: Aaron Hillegass
> Attachments: qpidc-0.6-no-tss.patch.bz2
>
>
> A lack of thread-local storage prevents a build on the Mac:
> g++ -DHAVE_CONFIG_H -I. -Igen -I./gen -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -g -O2 -MT qpid/sys/posix/AsynchIO.lo -MD -MP -MF qpid/sys/posix/.deps/AsynchIO.Tpo -c qpid/sys/posix/AsynchIO.cpp -fno-common -DPIC -o qpid/sys/posix/.libs/AsynchIO.o
> qpid/sys/posix/AsynchIO.cpp:61: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:62: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:63: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:64: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:65: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:66: error: thread-local storage not supported for this target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2206) thread-local storage prevents build on
Mac
Posted by "Dmitry Utkin (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Utkin updated QPID-2206:
-------------------------------
Attachment: qpidc-0.6-no-tss.patch.bz2
Sorry for my bad english.
I wrote patch that fixes problem with thread specific storage on linux, when compiler lacks __thread support.
I think this patch can also fix issue.
this patch also fixes QPID problem when running broker or any client with linux kernels prior to 2.6.9:
2010-04-02 18:09:40 error IO worker thread exiting with unhandled exception: Bad address (qpid/sys/epoll/EpollPoller.cpp:327)
To apply this patch use(after unpacking patch):
patch -p1 -d qpidc-0.6 <qpidc-0.6-notls.patch
To compile qpid without __thread support:
make CXXFLAGS=-DQPID_NO_TSS=1
Tested on linux with kernel 2.4.32 and gcc 4.1.3.
> thread-local storage prevents build on Mac
> ------------------------------------------
>
> Key: QPID-2206
> URL: https://issues.apache.org/jira/browse/QPID-2206
> Project: Qpid
> Issue Type: Bug
> Components: Build Tools
> Affects Versions: 0.5
> Environment: Mac OS X 10.5, Xcode 3.2.1
> Reporter: Aaron Hillegass
> Attachments: qpidc-0.6-no-tss.patch.bz2
>
>
> A lack of thread-local storage prevents a build on the Mac:
> g++ -DHAVE_CONFIG_H -I. -Igen -I./gen -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -g -O2 -MT qpid/sys/posix/AsynchIO.lo -MD -MP -MF qpid/sys/posix/.deps/AsynchIO.Tpo -c qpid/sys/posix/AsynchIO.cpp -fno-common -DPIC -o qpid/sys/posix/.libs/AsynchIO.o
> qpid/sys/posix/AsynchIO.cpp:61: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:62: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:63: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:64: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:65: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:66: error: thread-local storage not supported for this target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2206) thread-local storage prevents build
on Mac
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778956#action_12778956 ]
Steve Huston commented on QPID-2206:
------------------------------------
Apparantly g++ on OS X doesn't support __thread. You will need to either remove the __thread usage in the OS X version of AsynchIO.cpp or develop a replacement for QPID_TSS/__thread that uses run-time TSS instead of compile-time.
> thread-local storage prevents build on Mac
> ------------------------------------------
>
> Key: QPID-2206
> URL: https://issues.apache.org/jira/browse/QPID-2206
> Project: Qpid
> Issue Type: Bug
> Components: Build Tools
> Affects Versions: 0.5
> Environment: Mac OS X 10.5, Xcode 3.2.1
> Reporter: Aaron Hillegass
>
> A lack of thread-local storage prevents a build on the Mac:
> g++ -DHAVE_CONFIG_H -I. -Igen -I./gen -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -g -O2 -MT qpid/sys/posix/AsynchIO.lo -MD -MP -MF qpid/sys/posix/.deps/AsynchIO.Tpo -c qpid/sys/posix/AsynchIO.cpp -fno-common -DPIC -o qpid/sys/posix/.libs/AsynchIO.o
> qpid/sys/posix/AsynchIO.cpp:61: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:62: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:63: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:64: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:65: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:66: error: thread-local storage not supported for this target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2206) thread-local storage prevents build
on Mac
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854301#action_12854301 ]
Andrew Stitcher commented on QPID-2206:
---------------------------------------
I think the small part of the patch which allows Linux 2.6.9 and earlier to be used should be split from this jira. It's really not an issue OS X.
> thread-local storage prevents build on Mac
> ------------------------------------------
>
> Key: QPID-2206
> URL: https://issues.apache.org/jira/browse/QPID-2206
> Project: Qpid
> Issue Type: Bug
> Components: Build Tools
> Affects Versions: 0.5
> Environment: Mac OS X 10.5, Xcode 3.2.1
> Reporter: Aaron Hillegass
> Attachments: qpidc-0.6-no-tss.patch.bz2
>
>
> A lack of thread-local storage prevents a build on the Mac:
> g++ -DHAVE_CONFIG_H -I. -Igen -I./gen -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -g -O2 -MT qpid/sys/posix/AsynchIO.lo -MD -MP -MF qpid/sys/posix/.deps/AsynchIO.Tpo -c qpid/sys/posix/AsynchIO.cpp -fno-common -DPIC -o qpid/sys/posix/.libs/AsynchIO.o
> qpid/sys/posix/AsynchIO.cpp:61: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:62: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:63: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:64: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:65: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:66: error: thread-local storage not supported for this target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Issue Comment Edited: (QPID-2206) thread-local storage
prevents build on Mac
Posted by "Dmitry Utkin (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853345#action_12853345 ]
Dmitry Utkin edited comment on QPID-2206 at 4/6/10 12:03 PM:
-------------------------------------------------------------
Sorry for my bad english.
I wrote patch that fixes problem with thread specific storage on linux, when compiler lacks __thread support.
I think this patch can also fix issue.
this patch also fixes QPID problem when running broker or any client with linux kernels prior to 2.6.9:
2010-04-02 18:09:40 error IO worker thread exiting with unhandled exception: Bad address (qpid/sys/epoll/EpollPoller.cpp:327)
To apply this patch use(after unpacking):
patch -p1 -d qpidc-0.6 <qpidc-0.6-no-tss.patch
To compile qpid without __thread support:
make CXXFLAGS=-DQPID_NO_TSS=1
Tested on linux with kernel 2.4.32 and gcc 4.1.3.
was (Author: loentar):
Sorry for my bad english.
I wrote patch that fixes problem with thread specific storage on linux, when compiler lacks __thread support.
I think this patch can also fix issue.
this patch also fixes QPID problem when running broker or any client with linux kernels prior to 2.6.9:
2010-04-02 18:09:40 error IO worker thread exiting with unhandled exception: Bad address (qpid/sys/epoll/EpollPoller.cpp:327)
To apply this patch use(after unpacking patch):
patch -p1 -d qpidc-0.6 <qpidc-0.6-notls.patch
To compile qpid without __thread support:
make CXXFLAGS=-DQPID_NO_TSS=1
Tested on linux with kernel 2.4.32 and gcc 4.1.3.
> thread-local storage prevents build on Mac
> ------------------------------------------
>
> Key: QPID-2206
> URL: https://issues.apache.org/jira/browse/QPID-2206
> Project: Qpid
> Issue Type: Bug
> Components: Build Tools
> Affects Versions: 0.5
> Environment: Mac OS X 10.5, Xcode 3.2.1
> Reporter: Aaron Hillegass
> Attachments: qpidc-0.6-no-tss.patch.bz2
>
>
> A lack of thread-local storage prevents a build on the Mac:
> g++ -DHAVE_CONFIG_H -I. -Igen -I./gen -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -g -O2 -MT qpid/sys/posix/AsynchIO.lo -MD -MP -MF qpid/sys/posix/.deps/AsynchIO.Tpo -c qpid/sys/posix/AsynchIO.cpp -fno-common -DPIC -o qpid/sys/posix/.libs/AsynchIO.o
> qpid/sys/posix/AsynchIO.cpp:61: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:62: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:63: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:64: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:65: error: thread-local storage not supported for this target
> qpid/sys/posix/AsynchIO.cpp:66: error: thread-local storage not supported for this target
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org