[jira] [Commented] (FLINK-5133) Support to set resource for operator in DataStream and DataSet

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882685#comment-15882685 ] 

ASF GitHub Bot commented on FLINK-5133:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3303
  
    The code here looks very good, with a few minor comments.
    
    The main problem is as you mentioned: We are adding something to the API that is not yet supported by the runtime. We have done this before and it always confused users.
    
    If this pull request is changed to "hide" the public API part (like commenting out the public getters and setters), then most of the changes are hidden. It looks like most of the internal code also depends on public getters and hence needs to be commented out as well.
    
    What do you think we should do?


> Support to set resource for operator in DataStream and DataSet
> --------------------------------------------------------------
>
>                 Key: FLINK-5133
>                 URL: https://issues.apache.org/jira/browse/FLINK-5133
>             Project: Flink
>          Issue Type: Sub-task
>          Components: DataSet API, DataStream API
>            Reporter: zhijiang
>            Assignee: zhijiang
>
> This is part of the fine-grained resource configuration.
> For *DataStream*, the *setResource* API will be setted onto *SingleOutputStreamOperator* similar with other existing properties like parallelism, name, etc.
> For *DataSet*, the *setResource* API will be setted onto *Operator* in the similar way.
> There are two parameters described with minimum *ResourceSpec* and maximum *ResourceSpec* separately in the API for considering resource resize in future improvements.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)