You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by mu...@apache.org on 2006/06/02 21:40:50 UTC

svn commit: r411266 - /xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInputDebugger.java

Author: mullan
Date: Fri Jun  2 12:40:50 2006
New Revision: 411266

URL: http://svn.apache.org/viewvc?rev=411266&view=rev
Log:
Fix findbugs bug:
Nullcheck of value previously dereferenced.

Modified:
    xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInputDebugger.java

Modified: xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInputDebugger.java
URL: http://svn.apache.org/viewvc/xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInputDebugger.java?rev=411266&r1=411265&r2=411266&view=diff
==============================================================================
--- xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInputDebugger.java (original)
+++ xml/security/trunk/src/org/apache/xml/security/signature/XMLSignatureInputDebugger.java Fri Jun  2 12:40:50 2006
@@ -596,23 +596,23 @@
 
 		length = data.length();
 
-		if ((data != null) && (length > 0)) {
-			this._writer.write(" ");
+		if (length > 0) {
+		    this._writer.write(" ");
 
-			for (int i = 0; i < length; i++) {
-				char c = data.charAt(i);
+		    for (int i = 0; i < length; i++) {
+			char c = data.charAt(i);
 
-				switch (c) {
+			switch (c) {
 
-				case 0x0D:
-					this._writer.write("&amp;#xD;");
-					break;
-
-				default:
-					this._writer.write(c);
-					break;
-				}
+			    case 0x0D:
+				this._writer.write("&amp;#xD;");
+				break;
+
+			    default:
+				this._writer.write(c);
+				break;
 			}
+		    }
 		}
 
 		this._writer.write("?&gt;");
@@ -711,4 +711,4 @@
 			}
 		}
 	}
-}
\ No newline at end of file
+}