[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #20670: feat: Add resize drag handle to Dataset SQL fields

[GitBox <gi...@apache.org>]

Antonio-RiveroMartnez commented on code in PR #20670:
URL: https://github.com/apache/superset/pull/20670#discussion_r918088338


##########
superset-frontend/src/explore/components/controls/TextAreaControl.jsx:
##########
@@ -55,6 +65,8 @@ const defaultProps = {
   maxLines: 10,
   offerEditInModal: true,
   readOnly: false,
+  resize: false,

Review Comment:
   `resize` is not of type `boolean` from the declaration above.



##########
superset-frontend/src/explore/components/controls/TextAreaControl.jsx:
##########
@@ -45,6 +45,16 @@ const propTypes = {
   ]),
   aboveEditorSection: PropTypes.node,
   readOnly: PropTypes.bool,
+  resize: PropTypes.oneOf([
+    null,

Review Comment:
   Are `null` and `none` the same?



##########
superset-frontend/src/components/Datasource/CollectionTable.tsx:
##########
@@ -335,6 +343,13 @@ export default class CRUDCollection extends React.PureComponent<
     );
   }
 
+  getCellProps(record: any, col: any) {
+    const cellPropsFn =
+      this.props.itemCellProps && this.props.itemCellProps[col];

Review Comment:
   `this.props.itemCellProps?.[col]` vs `this.props.itemCellProps && this.props.itemCellProps[col];` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org