[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16412: [feature][CLI] Add commands to run 'scanOffloadedLedgers'.

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #16412:
URL: https://github.com/apache/pulsar/pull/16412#discussion_r919597132


##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java:
##########
@@ -4467,4 +4467,18 @@ void setIsAllowAutoUpdateSchema(String namespace, boolean isAllowAutoUpdateSchem
      * @return
      */
     CompletableFuture<Void> removeNamespaceResourceGroupAsync(String namespace);
+
+    /**
+     * Scan offloaded ledgers on a namespace.
+     * @param namespace
+     * @return
+     */
+    String scanOffloadedLedgers(String namespace) throws PulsarAdminException;

Review Comment:
   It is better to have a Pojo for the new API? I'm not sure why #14930 makes the response return a String, not an `OffloadedLedgersStats` or `OffloadedLedgersInfo`. For the admin, returning an Object will be better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org