You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2013/05/04 12:38:40 UTC
[1/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-26325 Added
setToStringExcludes and some obvious minor performance improvements
Updated Branches:
refs/heads/develop 8d6367aae -> 1ff125fcf
FLEX-26325 Added setToStringExcludes and some obvious minor performance improvements
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/3e740edb
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/3e740edb
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/3e740edb
Branch: refs/heads/develop
Commit: 3e740edb811e506ebcfb649d66d8ff6c3cfbbd1a
Parents: 8d6367a
Author: Justin Mclean <jm...@apache.org>
Authored: Sat May 4 19:10:37 2013 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Sat May 4 19:10:37 2013 +1000
----------------------------------------------------------------------
.../projects/rpc/src/mx/utils/RPCObjectUtil.as | 42 ++++++++++-----
1 files changed, 29 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3e740edb/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as b/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as
index 70bd175..0901c59 100644
--- a/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as
+++ b/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as
@@ -57,7 +57,19 @@ public class RPCObjectUtil
//
//--------------------------------------------------------------------------
-
+ /**
+ * Change deault set of strings to exclude.
+ *
+ * @langversion 3.0
+ * @playerversion Flash 9
+ * @playerversion AIR 1.1
+ * @productversion ApacheFlex 4.10
+ */
+ public static function setToStringExcludes(excludes:Array):void
+ {
+ defaultToStringExcludes = excludes;
+ }
+
/**
* Pretty-prints the specified Object into a String.
* All properties will be in alpha ordering.
@@ -230,6 +242,7 @@ public class RPCObjectUtil
{
var str:String;
var type:String = value == null ? "null" : typeof(value);
+
switch (type)
{
case "boolean":
@@ -293,7 +306,8 @@ public class RPCObjectUtil
indent += 2;
// Print all of the variable values.
- for (var j:int = 0; j < properties.length; j++)
+ var length:int = properties.length;
+ for (var j:int = 0; j < length; j++)
{
str = newline(str, indent);
prop = properties[j];
@@ -356,12 +370,12 @@ public class RPCObjectUtil
* This method will append a newline and the specified number of spaces
* to the given string.
*/
- private static function newline(str:String, n:int = 0):String
+ private static function newline(str:String, length:int = 0):String
{
var result:String = str;
result += "\n";
- for (var i:int = 0; i < n; i++)
+ for (var i:int = 0; i < length; i++)
{
result += " ";
}
@@ -413,7 +427,7 @@ public class RPCObjectUtil
excludes:Array = null,
options:Object = null):Object
{
- var n:int;
+ var length:int;
var i:int;
// this version doesn't handle ObjectProxy
@@ -475,8 +489,8 @@ public class RPCObjectUtil
var excludeObject:Object = {};
if (excludes)
{
- n = excludes.length;
- for (i = 0; i < n; i++)
+ length = excludes.length;
+ for (i = 0; i < length; i++)
{
excludeObject[excludes[i]] = 1;
}
@@ -512,8 +526,8 @@ public class RPCObjectUtil
}
else if (className == "XML")
{
- n = properties.length();
- for (i = 0; i < n; i++)
+ length = properties.length();
+ for (i = 0; i < length; i++)
{
p = properties[i].name();
if (excludeObject[p] != 1)
@@ -522,11 +536,11 @@ public class RPCObjectUtil
}
else
{
- n = properties.length();
+ length = properties.length();
var uris:Array = options.uris;
var uri:String;
var qName:QName;
- for (i = 0; i < n; i++)
+ for (i = 0; i < length; i++)
{
prop = properties[i];
p = prop.@name.toString();
@@ -593,7 +607,8 @@ public class RPCObjectUtil
propertyNames.sort(Array.CASEINSENSITIVE |
(numericIndex ? Array.NUMERIC : 0));
// remove any duplicates, i.e. any items that can't be distingushed by toString()
- for (i = 0; i < propertyNames.length - 1; i++)
+ length = propertyNames.length;
+ for (i = 0; i < length - 1; i++)
{
// the list is sorted so any duplicates should be adjacent
// two properties are only equal if both the uri and local name are identical
@@ -706,7 +721,8 @@ public class RPCObjectUtil
if (excludes != null)
{
- for (var i:uint = 0; i < excludes.length; i++)
+ var length:int = excludes.length;
+ for (var i:uint = 0; i < length; i++)
{
var excl:String = excludes[i] as String;
if (excl != null)
[4/5] git commit: [flex-sdk] [refs/heads/develop] - watch out for RTEs
Posted by jm...@apache.org.
watch out for RTEs
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/4d6fe4cf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/4d6fe4cf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/4d6fe4cf
Branch: refs/heads/develop
Commit: 4d6fe4cf6fa9975d9ea33878ab353a68404d27bb
Parents: 6d6a797
Author: Justin Mclean <jm...@apache.org>
Authored: Sat May 4 20:36:23 2013 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Sat May 4 20:36:23 2013 +1000
----------------------------------------------------------------------
.../projects/framework/src/mx/utils/ObjectUtil.as | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4d6fe4cf/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/utils/ObjectUtil.as b/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
index 4669383..742d978 100644
--- a/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
+++ b/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
@@ -1293,10 +1293,10 @@ public class ObjectUtil
private static function getCacheKey(o:Object, excludes:Array = null, options:Object = null):String
{
var key:String = getQualifiedClassName(o);
- var length:int = excludes.length;
if (excludes != null)
{
+ var length:int = excludes.length;
for (var i:uint = 0; i < length; i++)
{
var excl:String = excludes[i] as String;
[3/5] git commit: [flex-sdk] [refs/heads/develop] - Should check
array length outside of loop.
Posted by jm...@apache.org.
Should check array length outside of loop.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/6d6a7979
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/6d6a7979
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/6d6a7979
Branch: refs/heads/develop
Commit: 6d6a7979bb851694e8f3e1e46eee340efffa2660
Parents: a297401
Author: Justin Mclean <jm...@apache.org>
Authored: Sat May 4 20:29:30 2013 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Sat May 4 20:29:30 2013 +1000
----------------------------------------------------------------------
.../projects/framework/src/mx/utils/ObjectUtil.as | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/6d6a7979/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/utils/ObjectUtil.as b/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
index 62fd147..4669383 100644
--- a/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
+++ b/frameworks/projects/framework/src/mx/utils/ObjectUtil.as
@@ -1293,10 +1293,11 @@ public class ObjectUtil
private static function getCacheKey(o:Object, excludes:Array = null, options:Object = null):String
{
var key:String = getQualifiedClassName(o);
-
+ var length:int = excludes.length;
+
if (excludes != null)
{
- for (var i:uint = 0; i < excludes.length; i++)
+ for (var i:uint = 0; i < length; i++)
{
var excl:String = excludes[i] as String;
if (excl != null)
[5/5] git commit: [flex-sdk] [refs/heads/develop] - Fixed same issue
as reported in FLEX-18697
Posted by jm...@apache.org.
Fixed same issue as reported in FLEX-18697
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/1ff125fc
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/1ff125fc
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/1ff125fc
Branch: refs/heads/develop
Commit: 1ff125fcfdf5542c69ff8aa452f65cdbe7b41cad
Parents: 4d6fe4c
Author: Justin Mclean <jm...@apache.org>
Authored: Sat May 4 20:38:24 2013 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Sat May 4 20:38:24 2013 +1000
----------------------------------------------------------------------
.../projects/rpc/src/mx/utils/RPCObjectUtil.as | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/1ff125fc/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as b/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as
index 0901c59..52c23da 100644
--- a/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as
+++ b/frameworks/projects/rpc/src/mx/utils/RPCObjectUtil.as
@@ -735,9 +735,9 @@ public class RPCObjectUtil
for (var flag:String in options)
{
key += flag;
- var value:String = options[flag] as String;
- if (value != null)
- key += value;
+ var value:String = options[flag];
+ if (value != null)
+ key += value.toString();
}
}
return key;
[2/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-26325 Minor
performance improvement
Posted by jm...@apache.org.
FLEX-26325 Minor performance improvement
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/a2974011
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/a2974011
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/a2974011
Branch: refs/heads/develop
Commit: a29740118643780dd4459b523aa4bfcb6a01dcdb
Parents: 3e740ed
Author: Justin Mclean <jm...@apache.org>
Authored: Sat May 4 19:11:16 2013 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Sat May 4 19:11:16 2013 +1000
----------------------------------------------------------------------
.../src/mx/messaging/messages/AbstractMessage.as | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/a2974011/frameworks/projects/rpc/src/mx/messaging/messages/AbstractMessage.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/rpc/src/mx/messaging/messages/AbstractMessage.as b/frameworks/projects/rpc/src/mx/messaging/messages/AbstractMessage.as
index 9f51254..97d79ab 100644
--- a/frameworks/projects/rpc/src/mx/messaging/messages/AbstractMessage.as
+++ b/frameworks/projects/rpc/src/mx/messaging/messages/AbstractMessage.as
@@ -689,7 +689,8 @@ public class AbstractMessage implements IMessage
}
propertyNames.sort();
- for (var i:uint = 0; i < propertyNames.length; i++)
+ var length:int = propertyNames.length;
+ for (var i:uint = 0; i < length; i++)
{
var name:String = String(propertyNames[i]);
var value:String = RPCObjectUtil.toString(attributes[name]);