You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "xijiu (via GitHub)" <gi...@apache.org> on 2024/09/05 07:36:04 UTC
[PR] MINOR: Simplify the test for `ListOffsetsRequestTest#testListOffsetsRequestOldestVersion` [kafka]
xijiu opened a new pull request, #17100:
URL: https://github.com/apache/kafka/pull/17100
The junit test `ListOffsetsRequestTest#testListOffsetsRequestOldestVersion` is defined by:
```
@ParameterizedTest
@ValueSource(strings = Array("zk", "kraft"))
```
But the method just need the simple test, it do not need test the `zk` or `kraft` mode
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Simplify the test for `ListOffsetsRequestTest#testListOffsetsRequestOldestVersion` [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17100:
URL: https://github.com/apache/kafka/pull/17100#discussion_r1745327576
##########
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##########
@@ -92,8 +93,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
assertResponseError(Errors.NOT_LEADER_OR_FOLLOWER, nonReplica, debugReplicaRequest)
}
- @ParameterizedTest
- @ValueSource(strings = Array("zk", "kraft"))
+ @Test
Review Comment:
Could you please move this test to https://github.com/apache/kafka/blob/trunk/clients/src/test/java/org/apache/kafka/common/requests/ListOffsetsRequestTest.java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Simplify the test for `ListOffsetsRequestTest#testListOffsetsRequestOldestVersion` [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17100:
URL: https://github.com/apache/kafka/pull/17100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org