You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <ch...@yahoo-inc.com> on 2012/04/02 22:22:13 UTC
Re: Review Request: OOZIE-797 Action retry not reading default error code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4576/
-----------------------------------------------------------
(Updated 2012-04-02 20:22:13.410404)
Review request for oozie.
Changes
-------
incorporated review comments. Added test case
Summary
-------
the oozie-default:
<name>oozie.service.LiteWorkflowStoreService.user.retry.error.code</name>
<value>
JA008,
JA009,
JA017,
JA018,
JA019,
FS009,
FS008
</value>
but the action failed these error codes, is not retried. Retry works if this property is specified in oozie-site.xml
This problem is resolved by creating the error codes Set after eliminating whitespaces if any.
This addresses bug OOZIE-797.
https://issues.apache.org/jira/browse/OOZIE-797
Diffs (updated)
-----
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1308501
trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java 1308501
Diff: https://reviews.apache.org/r/4576/diff
Testing
-------
yes
Thanks,
Mona
Re: Review Request: OOZIE-797 Action retry not reading default error code.
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4576/#review6649
-----------------------------------------------------------
Ship it!
+1 committing
- Mohammad
On 2012-04-02 22:14:01, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4576/
> -----------------------------------------------------------
>
> (Updated 2012-04-02 22:14:01)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> the oozie-default:
>
> <name>oozie.service.LiteWorkflowStoreService.user.retry.error.code</name>
> <value>
> JA008,
> JA009,
> JA017,
> JA018,
> JA019,
> FS009,
> FS008
> </value>
>
> but the action failed these error codes, is not retried. Retry works if this property is specified in oozie-site.xml
>
> This problem is resolved by creating the error codes Set after eliminating whitespaces if any.
>
>
> This addresses bug OOZIE-797.
> https://issues.apache.org/jira/browse/OOZIE-797
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java 1308501
> trunk/core/src/main/resources/oozie-default.xml 1308501
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1308501
>
> Diff: https://reviews.apache.org/r/4576/diff
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-797 Action retry not reading default error code.
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4576/#review6642
-----------------------------------------------------------
Ship it!
+1 after minor comment about whitespace
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java
<https://reviews.apache.org/r/4576/#comment14344>
whitespace
- Virag
On 2012-04-02 22:14:01, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4576/
> -----------------------------------------------------------
>
> (Updated 2012-04-02 22:14:01)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> the oozie-default:
>
> <name>oozie.service.LiteWorkflowStoreService.user.retry.error.code</name>
> <value>
> JA008,
> JA009,
> JA017,
> JA018,
> JA019,
> FS009,
> FS008
> </value>
>
> but the action failed these error codes, is not retried. Retry works if this property is specified in oozie-site.xml
>
> This problem is resolved by creating the error codes Set after eliminating whitespaces if any.
>
>
> This addresses bug OOZIE-797.
> https://issues.apache.org/jira/browse/OOZIE-797
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java 1308501
> trunk/core/src/main/resources/oozie-default.xml 1308501
> trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1308501
>
> Diff: https://reviews.apache.org/r/4576/diff
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-797 Action retry not reading default error code.
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4576/
-----------------------------------------------------------
(Updated 2012-04-02 22:14:01.138052)
Review request for oozie.
Changes
-------
added correction to oozie-default.xml
modified testcase to test only the codes lookup, instead of a complete action retry execution
Summary
-------
the oozie-default:
<name>oozie.service.LiteWorkflowStoreService.user.retry.error.code</name>
<value>
JA008,
JA009,
JA017,
JA018,
JA019,
FS009,
FS008
</value>
but the action failed these error codes, is not retried. Retry works if this property is specified in oozie-site.xml
This problem is resolved by creating the error codes Set after eliminating whitespaces if any.
This addresses bug OOZIE-797.
https://issues.apache.org/jira/browse/OOZIE-797
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java 1308501
trunk/core/src/main/resources/oozie-default.xml 1308501
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1308501
Diff: https://reviews.apache.org/r/4576/diff
Testing
-------
yes
Thanks,
Mona