You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/11/22 22:48:23 UTC
[GitHub] [royale-asjs] estanglerbm opened a new pull request #948: Removed mx.messaging.channels.URLVariables, and switched to using org.apache.royale.net.URLVariables for HTTPService.request in MXRoyale / SparkRoyale.
estanglerbm opened a new pull request #948:
URL: https://github.com/apache/royale-asjs/pull/948
HTTPService is unable to send HTTP GET parameters, specified in the request member, without an implementation of URLVariables.
After doing a trivial implementation that leveraged the existing org.apache.royale.net.URLVariables, @greg-dove suggested that I remove the MX version of URLVariables and just use the Royale version.
This pull request replaces #942.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] greg-dove merged pull request #948: Removed mx.messaging.channels.URLVariables, and switched to using org.apache.royale.net.URLVariables for HTTPService.request in MXRoyale / SparkRoyale.
Posted by GitBox <gi...@apache.org>.
greg-dove merged pull request #948:
URL: https://github.com/apache/royale-asjs/pull/948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] estanglerbm commented on pull request #948: Removed mx.messaging.channels.URLVariables, and switched to using org.apache.royale.net.URLVariables for HTTPService.request in MXRoyale / SparkRoyale.
Posted by GitBox <gi...@apache.org>.
estanglerbm commented on pull request #948:
URL: https://github.com/apache/royale-asjs/pull/948#issuecomment-731860846
@greg-dove: Thanks for the comments on the original pull request. It's fine either way. As long as I don't have to custom build MXRoyale for this change in future releases!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] greg-dove commented on pull request #948: Removed mx.messaging.channels.URLVariables, and switched to using org.apache.royale.net.URLVariables for HTTPService.request in MXRoyale / SparkRoyale.
Posted by GitBox <gi...@apache.org>.
greg-dove commented on pull request #948:
URL: https://github.com/apache/royale-asjs/pull/948#issuecomment-731863606
Thanks heaps.
> As long as I don't have to custom build MXRoyale for this change in future releases!
We definitely prefer working code, so your contribution is most welcome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org