You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/12 04:00:54 UTC

[GitHub] [skywalking] arugal commented on a change in pull request #8408: Add faas to SpanLayer

arugal commented on a change in pull request #8408:
URL: https://github.com/apache/skywalking/pull/8408#discussion_r782692855



##########
File path: oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/MultiScopesAnalysisListener.java
##########
@@ -390,6 +390,8 @@ private Layer fromSpanLayerValue(SpanLayer spanLayer) {
                 return Layer.CACHE;
             case UNRECOGNIZED:
                 return Layer.UNDEFINED;
+            case FAAS:
+                return Layer.FAAS;

Review comment:
       Need to return `Layer.GENERAL` by default? I'm not sure @wu-sheng @wankai123 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org