[jira] [Commented] (HIVE-18038) org.apache.hadoop.hive.ql.session.OperationLog - Review

["Peter Vary (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247424#comment-16247424 ] 

Peter Vary commented on HIVE-18038:
-----------------------------------

[~belugabehr]: I am in a little hurry (last working day before a week pto) so my review is far from complete, but have a few concerns:
- Removing the null check from {{private void resetIn()}} - this is used at multiple places, and might cause problems at other places. Like if the following line throws an exception: {{in = new BufferedReader(new InputStreamReader(new FileInputStream(file)));}}, and the user tries {{read(boolean isFetchFirst, long maxRows)}} twice
- Moving {{logs.add("Reading log file: " + file);}} to other place might extra lines to the logs not just to the first line, but into the middle as well, if there are more lines in the log file, than the {{nLines}}

Thanks,
Peter

> org.apache.hadoop.hive.ql.session.OperationLog - Review
> -------------------------------------------------------
>
>                 Key: HIVE-18038
>                 URL: https://issues.apache.org/jira/browse/HIVE-18038
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HIVE-18038.1.patch
>
>
> Simplifications, improve readability



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)